You need to
before you can comment on or make changes to this bug.
fill-modes are a new webkit CSS concept that allows for compound sequential animations.
This needs to be special-cased in GraphicsLayer.
Created an attachment (id=53576) [details]
implemet fill modes in GraphicsLayerQt
r=me, please remove the unused fillBackwards function
Created an attachment (id=53580) [details]
removed unnecessary function
(From update of attachment 53580 [details])
Clearing flags on attachment: 53580
Committed r57770: <http://trac.webkit.org/changeset/57770>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/57770 might have broken Qt Linux Release
(In reply to comment #6)
> http://trac.webkit.org/changeset/57770 might have broken Qt Linux Release
Rollout committed in http://trac.webkit.org/changeset/57776
rollout bug: https://bugs.webkit.org/show_bug.cgi?id=37746
crashed caused by the original bug: http://build.webkit.org/results/Qt%20Linux%20Release/r57770%20%2810253%29/results.html
First I tried to do a clean build, but it didn't resolve the crashes,
so I had to rollout the patch.
(From update of attachment 53576 [details])
Cleared Antti Koivisto's review+ from obsolete attachment 53576 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Created an attachment (id=53655) [details]
re-submitting the patch, this time with a couple of more null-checks I overlooked in the first patch. All the regressed tests worked for me after this patch.
(From update of attachment 53655 [details])
Rejecting patch 53655 from commit-queue.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog. See:
You are right, how could I have missed that :-(. I will r- it for that reason.
(In reply to comment #10)
> Created an attachment (id=53655) [details] [details]
> re-submitting the patch, this time with a couple of more null-checks I
> overlooked in the first patch. All the regressed tests worked for me after this
I tested it on bot, it will work without crashes.
Created an attachment (id=53695) [details]
changelog was mistakenly omitted from previous patch
(From update of attachment 53695 [details])
Clearing flags on attachment: 53695
Committed r57878: <http://trac.webkit.org/changeset/57878>
Revision r57878 cherry-picked into qtwebkit-2.0 with commit 6b307dc15ad5180ba95bb97df76f0cfcc2e8bf22