Bug 36216 – [Qt] GraphicsLayer: support fill-modes

• Status: CLOSED
• Resolution: FIXED
• Component: Layout and Rendering

[Noam Rosenthal]

fill-modes are a new webkit CSS concept that allows for compound sequential animations.
This needs to be special-cased in GraphicsLayer.

test: LayoutTests/animations/fill-mode-transform.html

[Noam Rosenthal]

Created attachment 53576 [details]
implemet fill modes in GraphicsLayerQt

[Antti Koivisto]

r=me, please remove the unused fillBackwards function

[Noam Rosenthal]

Created attachment 53580 [details]
removed unnecessary function

[WebKit Commit Bot]

Comment on attachment 53580 [details]
removed unnecessary function

Clearing flags on attachment: 53580

Committed r57770: <http://trac.webkit.org/changeset/57770>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/57770 might have broken Qt Linux Release

[Csaba Osztrogonác]

(In reply to comment #6)
> http://trac.webkit.org/changeset/57770 might have broken Qt Linux Release
Rollout committed in http://trac.webkit.org/changeset/57776

[Csaba Osztrogonác]

rollout bug: https://bugs.webkit.org/show_bug.cgi?id=37746
crashed caused by the original bug: http://build.webkit.org/results/Qt%20Linux%20Release/r57770%20%2810253%29/results.html

First I tried to do a clean build, but it didn't resolve the crashes,
so I had to rollout the patch.

[Eric Seidel (no email)]

Comment on attachment 53576 [details]
implemet fill modes in GraphicsLayerQt

Cleared Antti Koivisto's review+ from obsolete attachment 53576 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Noam Rosenthal]

Created attachment 53655 [details]
re-submitting the patch, this time with a couple of more null-checks I overlooked in the first patch. All the regressed tests worked for me after this patch.

[WebKit Commit Bot]

Comment on attachment 53655 [details]
re-submitting the patch, this time with a couple of more null-checks I overlooked in the first patch. All the regressed tests worked for me after this patch.

Rejecting patch 53655 from commit-queue.

Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html

[Kenneth Rohde Christiansen]

You are right, how could I have missed that :-(. I will r- it for that reason.

[Csaba Osztrogonác]

(In reply to comment #10)
> Created an attachment (id=53655) [details]
> re-submitting the patch, this time with a couple of more null-checks I
> overlooked in the first patch. All the regressed tests worked for me after this
> patch.

I tested it on bot, it will work without crashes.

[Noam Rosenthal]

Created attachment 53695 [details]
changelog was mistakenly omitted from previous patch

[WebKit Commit Bot]

Comment on attachment 53695 [details]
changelog was mistakenly omitted from previous patch

Clearing flags on attachment: 53695

Committed r57878: <http://trac.webkit.org/changeset/57878>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Hausmann]

Revision r57878 cherry-picked into qtwebkit-2.0 with commit 6b307dc15ad5180ba95bb97df76f0cfcc2e8bf22