Created attachment 50586 [details]
gdb backtrace: editing/deleting/5290534.html
original bug: https://bugs.webkit.org/show_bug.cgi?id=36041
Created attachment 50587 [details]
gdb backtrace: fast/events/key-events-in-input-text.html
Created attachment 50588 [details]
gdb backtrace: fast/forms/8250.html
Created attachment 50589 [details]
gdb backtrace: http/tests/navigation/anchor-basic.html
I attached four gdb backtrace. Have you got any idea how are these crashes related to UStringImpl patch and how to fix them?
Any chance you could test a change for me please, to see if it helps?
My guess is that the bug is that the QTextBoundaryFinder may be assuming that all non-null strings are at least one character long? – this patch changed empty()->characters() from 0 to 1 so that String("").characters() is distinct from String().characters().
It looks like the problem is in platform/text/qt/TextBreakIteratorQt.cpp, I'll attach a patch that should hopefully fix the issue for you.
apologies for the breakage, and thanks in advance,
Created attachment 50604 [details]
Patch for testing!
(In reply to comment #6)
> Created an attachment (id=50604) [details]
> Patch for testing!
I tested this patch, it fixes all crashes. Thanks for your help.
Awesome, cheers Ossy, just heading into the office, will get this reviewed & landed when I get there.
Thanks for testing, & apologies again for the breakage.
r+ in person from ggaren, fix landed in r55934.