Bug 36041 – Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Gavin Barraclough]

Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar, but has trivial and unnecessary formatting differences, such as the exact wording of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.

[Gavin Barraclough]

Created attachment 50564 [details]
Not setting r flag, abusing bugzilla to give me a pretty diff to get better comment per-function changes in my ChangeLog entries!

[Gavin Barraclough]

Created attachment 50569 [details]
The patch

Shows as a ~0.5% - 1% progression on SunSpider on my laptop.
This may be noise, through is repeatable & predominately seemed to come from moving the infrequently used UStringImpl::create() methods from the .h into the .cpp.

[WebKit Review Bot]

Attachment 50569 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/runtime/UStringImpl.h:256:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/runtime/UStringImpl.h:256:  More than one command on the same line in if  [whitespace/parens] [4]
JavaScriptCore/runtime/UStringImpl.h:257:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/text/StringImpl.h:170:  More than one command on the same line  [whitespace/newline] [4]
WebCore/platform/text/StringImpl.h:170:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 5 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

Comment on attachment 50569 [details]
The patch

r=me

[Gavin Barraclough]

Comitted r55878