Bug 35968 - [Qt] QScriptValuePrivate::States has naming issues
Summary: [Qt] QScriptValuePrivate::States has naming issues
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Jędrzej Nowacki
Keywords: Qt
Depends on:
Blocks: 31863
  Show dependency treegraph
Reported: 2010-03-10 05:37 PST by Jędrzej Nowacki
Modified: 2010-03-11 21:41 PST (History)
1 user (show)

See Also:

Fix v1 (9.08 KB, patch)
2010-03-10 06:08 PST, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-03-10 05:37:53 PST
- The enum States has invalid name, according to Qt coding style it should be "State" as enum's elements are not flags that could be or'ed or and'ed.
- JSNative should be renamed to JSPrimitive as "primitive value" is a corresponding name in ECMA Script standard ("A primitive value is a member of one of the following built-in types: Undefined, Null, Boolean, Number, and String").
Comment 1 Jędrzej Nowacki 2010-03-10 06:08:36 PST
Created attachment 50397 [details]
Fix v1
Comment 2 WebKit Commit Bot 2010-03-11 21:41:48 PST
Comment on attachment 50397 [details]
Fix v1

Clearing flags on attachment: 50397

Committed r55887: <http://trac.webkit.org/changeset/55887>
Comment 3 WebKit Commit Bot 2010-03-11 21:41:52 PST
All reviewed patches have been landed.  Closing bug.