Bug 35918 – [EFL] Add EditorClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Leandro Pereira]

+++ This bug was initially created as a clone of Bug #35059 +++

Attached patch adds EFL's implementation of EditorClientEfl to
WebKit/efl/WebCoreSupport.

[Leandro Pereira]

Created attachment 50301 [details]
Add EditorClientEfl to WK/efl/WebCoreSupport.

[Holger Freyther]

It would be nice if you could share this table with the Gtk+ port somehow. Or at least create a follow up patch patching both Gtk and Efl to mention the others copy of the table and that they need to be kept in sync.... It would be preferable to not have that duplication.

[Leandro Pereira]

(In reply to comment #2)
> It would be nice if you could share this table with the Gtk+ port somehow. Or
> at least create a follow up patch patching both Gtk and Efl to mention the
> others copy of the table and that they need to be kept in sync.... It would be
> preferable to not have that duplication.

There's a copy of this table in other ports, too (at least with this same name): Wx and Chromium. Do you have any ideas on how this table could be shared amongst all ports that use it, besides having a comment to keep them in sync?

[Kenneth Rohde Christiansen]

Comment on attachment 50301 [details]
Add EditorClientEfl to WK/efl/WebCoreSupport.

LGTM

[WebKit Commit Bot]

Comment on attachment 50301 [details]
Add EditorClientEfl to WK/efl/WebCoreSupport.

Clearing flags on attachment: 50301

Committed r57665: <http://trac.webkit.org/changeset/57665>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.