Bug 35916 – [EFL] Add ContextMenuClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Leandro Pereira]

+++ This bug was initially created as a clone of Bug #35059 +++

Attached patch adds EFL's implementation of ContextMenuClient to
WebKit/efl/WebCoreSupport.

[Leandro Pereira]

Created attachment 50299 [details]
Add ContextMEnuClientEfl to WK/efl/WebCoreSupport.

[Eric Seidel (no email)]

Comment on attachment 50299 [details]
Add ContextMEnuClientEfl to WK/efl/WebCoreSupport. 

Style error:
 56     Evas_Object *m_view;

WebCore:: is not needed in a bunch of these:
+    virtual void searchWithGoogle(const WebCore::Frame*);

All these copyrights in the .h file aren't needed:
+/*
+ * Copyright (C) 2006 Zack Rusin <[e-mail]>
+ * Copyright (C) 2008 INdT - Instituto Nokia de Tecnologia
+ * Copyright (C) 2009-2010 ProFUSION embedded systems
+ * Copyright (C) 2009-2010 Samsung Electronics

[Eric Seidel (no email)]

The old copyrights, I mean.

[Leandro Pereira]

Created attachment 50787 [details]
 Add ContextMEnuClientEfl to WK/efl/WebCoreSupport.

[Kenneth Rohde Christiansen]

(In reply to comment #3)
> The old copyrights, I mean.

hmm, but if the code was based on older code with other copyright, you cannot just remove them, unless all of the code was rewritten.

[Kenneth Rohde Christiansen]

(In reply to comment #5)
> (In reply to comment #3)
> > The old copyrights, I mean.
> 
> hmm, but if the code was based on older code with other copyright, you cannot
> just remove them, unless all of the code was rewritten.

Ah sorry, I didn't notice it was just a stub :-)

[WebKit Commit Bot]

Comment on attachment 50787 [details]
 Add ContextMEnuClientEfl to WK/efl/WebCoreSupport. 

Clearing flags on attachment: 50787

Committed r56075: <http://trac.webkit.org/changeset/56075>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.