+++ This bug was initially created as a clone of Bug #35749 +++ +++ This bug was initially created as a clone of Bug #35087 +++ Forthcoming patch adds SoundEfl.cpp to WC/platform/efl.
Created attachment 50256 [details] Add SoundEfl.cpp to WC/platform/efl.
Comment on attachment 50256 [details] Add SoundEfl.cpp to WC/platform/efl. The list of copyright holders seems to be excessive for these two lines of code.
Created attachment 50410 [details] Add SoundEfl.cpp to WC/platform/efl. zecke already r+'d this patch -- this updated version only removes Apple copyright since there is no Apple code in it.
Comment on attachment 50410 [details] Add SoundEfl.cpp to WC/platform/efl. Clearing flags on attachment: 50410 Committed r56016: <http://trac.webkit.org/changeset/56016>
All reviewed patches have been landed. Closing bug.
Comment on attachment 50410 [details] Add SoundEfl.cpp to WC/platform/efl. Please use c++ style casts: 43 Display* display = (Display*) ecore_x_display_get(); Not needed: +#include "NotImplemented.h"
I'm sad that my review is too late and that Holger didn't see all the nits I saw. :(
(In reply to comment #7) > I'm sad that my review is too late and that Holger didn't see all the nits I > saw. :( I'll create follow-up patches.