Bug 35749 – New port: EFL; adding files to WebCore/platform/efl

• Status: RESOLVED
• Resolution: INVALID
• Component: Platform

[Leandro Pereira]

+++ This bug was initially created as a clone of Bug #35087 +++

Subject says it all.

[Leandro Pereira]

Created attachment 50034 [details]
Add files to WebCore/platform/efl.

[Eric Seidel (no email)]

Comment on attachment 50034 [details]
Add files to WebCore/platform/efl.

Please create paches with our tools (svn-create-patch or webkit-patch) so that they end up with the ChangeLog first in the diff. :)

Also this would be clearer to me as an even smaller diff.

[Leandro Pereira]

(In reply to comment #2)
> 
> Also this would be clearer to me as an even smaller diff.
>

How small? May I just attach the chunks here or create a bug report for each?

[Eric Seidel (no email)]

These are pretty much all logically distinct implementations.  They're easier to rubber-stamp one functional area at a time.  In the case of patches like this, although I may feel that your system time implementation is fine, I might have questions about the clipboard implementation.  Tying them together, just delays reviews. :(

[Leandro Pereira]

(In reply to comment #4)
> These are pretty much all logically distinct implementations.  They're easier
> to rubber-stamp one functional area at a time.  In the case of patches like
> this, although I may feel that your system time implementation is fine, I might
> have questions about the clipboard implementation.  Tying them together, just
> delays reviews. :(

OK. I'll clone this bug for each .cpp/.h pair. This should speed up the review process.

[Leandro Pereira]

I'm closing this bug since the patch included here was splitted into several other bug reports.