Bug 35885 – [EFL] Add KURLEfl.cpp to WC/platform/efl.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Leandro Pereira]

+++ This bug was initially created as a clone of Bug #35749 +++

+++ This bug was initially created as a clone of Bug #35087 +++

Forthcoming patch adds KURLEfl.cpp to WC/platform/efl.

[Leandro Pereira]

Created attachment 50254 [details]
Add KURLEfl.cpp to WC/platform/efl

[Holger Freyther]

Comment on attachment 50254 [details]
Add KURLEfl.cpp to WC/platform/efl


> +#include <Ecore.h>

the include is not needed.

> +
> +namespace WebCore {
> +
> +String KURL::fileSystemPath() const
> +{
> +    CString filename = m_string.utf8();
> +
> +    if (!filename.data())
> +        return String();
> +
> +    String path = String::fromUTF8(filename.data());
> +    return path;

The implementation is totally bogus. You can easily steal the KURLQt.cpp implementation
or at least take a look at that.

[Leandro Pereira]

Created attachment 50401 [details]
Add KURLEfl.cpp to WC/platform/efl

OK, copied the Qt implementation.

[Eric Seidel (no email)]

Comment on attachment 50401 [details]
Add KURLEfl.cpp to WC/platform/efl

OK.

Sad this can't be shared by ports that don't need special handling here.

[WebKit Commit Bot]

Comment on attachment 50401 [details]
Add KURLEfl.cpp to WC/platform/efl

Clearing flags on attachment: 50401

Committed r56023: <http://trac.webkit.org/changeset/56023>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.