WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
https://bugs.webkit.org/show_bug.cgi?id=35726
Summary
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
Dominik Röttsches (drott)
Reported
2010-03-04 01:14:42 PST
WTF_USE_GLIB_ICU_UNICODE_HYBRID is not needed/used anymore. The leftover usage in ThreadGlobalData.h needs to go away.
Attachments
removing the orphaned condition
(1.14 KB, patch)
2010-03-04 01:22 PST
,
Dominik Röttsches (drott)
no flags
Details
Formatted Diff
Diff
Patch to remove all orphaned occurences of GLIB_ICU_UNICODE_HYBRID
(2.71 KB, patch)
2010-03-04 05:48 PST
,
Fridrich Strba
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1
2010-03-04 01:22:09 PST
Created
attachment 49996
[details]
removing the orphaned condition
Fridrich Strba
Comment 2
2010-03-04 01:34:28 PST
There is one more instance of that define in that file and then there is the define in GNUMakefile.am
Fridrich Strba
Comment 3
2010-03-04 05:48:44 PST
Created
attachment 50007
[details]
Patch to remove all orphaned occurences of GLIB_ICU_UNICODE_HYBRID
Fridrich Strba
Comment 4
2010-03-04 05:52:26 PST
***
Bug 35704
has been marked as a duplicate of this bug. ***
Fridrich Strba
Comment 5
2010-03-04 05:53:17 PST
OK, I went through the sources and removed the orphaned mentions.
Holger Freyther
Comment 6
2010-03-04 05:56:15 PST
Comment on
attachment 50007
[details]
Patch to remove all orphaned occurences of GLIB_ICU_UNICODE_HYBRID Seems to be fine.
WebKit Commit Bot
Comment 7
2010-03-04 07:03:21 PST
Comment on
attachment 50007
[details]
Patch to remove all orphaned occurences of GLIB_ICU_UNICODE_HYBRID Clearing flags on attachment: 50007 Committed
r55524
: <
http://trac.webkit.org/changeset/55524
>
WebKit Commit Bot
Comment 8
2010-03-04 07:03:26 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug