Bug 35521 – [Android] The platform touch events on Android are missing support for key modifiers.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ben Murdoch]

This bug is to track upstreaming of support for key modifiers and event time in Touch Events on Android.

[Ben Murdoch]

Created attachment 50204 [details]
Proposed Patch.

Adds support for key modifiers in Android touch events. Also adds a platformEventTime member to touch events to reflect the time that the event was started on the platform side rather than the WebCore side. For example, on Android this is set to the Java side touch event time. Due to the asynchronous nature of Android's touch event handling, this platform time may be significantly different to the time that the event is constructed inside WebCore.

[Ben Murdoch]

Created attachment 50205 [details]
Patch sans-tab.

Removed a couple of tabs from the Changelog.

[Ben Murdoch]

Created attachment 50402 [details]
Proposed Patch.

[Ben Murdoch]

Please note that contrary to my comment #1, Android no longer needs support for platformEventTime, which is why it no longer appears in the patch.

[Jeremy Orlow]

Comment on attachment 50402 [details]
Proposed Patch.

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 55774)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,24 @@
> [phone]  Ben Murdoch  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Android] The platform touch events on Android are missing support
> +        for key modifiers.
> +        https://bugs.webkit.org/show_bug.cgi?id=35521
> +
> +        Add support in PlatformToucHEventAndroid for the platform supplying
> +        key modifiers with touch events.
> +
> +        Exisiting touch events test suffice.

Change this to say that you're making existing tests work that didn't before.

[Ben Murdoch]

Landed as r55843.