Bug 35445 - [OpenVG] Convert from TransformationMatrix to AffineTransform
Summary: [OpenVG] Convert from TransformationMatrix to AffineTransform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 35444
Blocks: 33987 34366
  Show dependency treegraph
 
Reported: 2010-02-26 12:34 PST by Jakob Petsovits
Modified: 2010-03-01 07:52 PST (History)
0 users

See Also:


Attachments
Patch (15.94 KB, patch)
2010-02-26 12:35 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff
Patch (15.42 KB, patch)
2010-02-26 13:05 PST, Jakob Petsovits
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2010-02-26 12:34:56 PST
[OpenVG] Convert from TransformationMatrix to AffineTransform
Comment 1 Jakob Petsovits 2010-02-26 12:35:30 PST
Created attachment 49615 [details]
Patch
Comment 2 Jakob Petsovits 2010-02-26 12:42:09 PST
krit's commit changed most of the graphics platform layer to operate with the new AffineTransform instead of TransformationMatrix. That patch did not, however, update the OpenVG backend - which is fair enough, as there's currently no publicly available way to build it.

This patch converts the already upstreamed parts of the OpenVG backend to use AffineTransform. krit said he'd get mapQuad() into AffineTransform too (that was originally left out), until that happens, I've got a private static function doing the same thing. We can clean it out afterwards.

Please review!
Comment 3 Nikolas Zimmermann 2010-02-26 12:59:38 PST
Comment on attachment 49615 [details]
Patch

Patch looks fine, r=me.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index cd85ac2..d539832 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,36 @@
> +2010-02-26  Jakob Petsovits  <jpetsovits@rim.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [OpenVG] Convert from TransformationMatrix to AffineTransform.
> +

the ChangeLog is missing a bug number and a good explainatain to why this is done.
It shouldn't be necessary to look in the bug to get that information :-)

Please fix before landing.
Comment 4 Jakob Petsovits 2010-02-26 13:05:05 PST
Created attachment 49627 [details]
Patch
Comment 5 Jakob Petsovits 2010-02-26 13:06:05 PST
New patch (above), with bug URL in the commit message and private mapQuad() copy removed, instead we depend on bug 35444 to add mapQuad() directly to AffineTransform. Yay.
Comment 6 Nikolas Zimmermann 2010-02-26 14:26:17 PST
Comment on attachment 49627 [details]
Patch

Great, r=me.
Comment 7 Jakob Petsovits 2010-03-01 07:52:26 PST
Committed r55369: <http://trac.webkit.org/changeset/55369>