Bug 35357 - Two editing tests fail after DumpRenderTree run loop changes
Summary: Two editing tests fail after DumpRenderTree run loop changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-24 13:18 PST by Alexey Proskuryakov
Modified: 2013-07-30 21:34 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (3.14 KB, patch)
2010-02-24 13:23 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed fix (5.61 KB, patch)
2010-02-24 13:42 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
your wish is my command (3.46 KB, patch)
2010-02-24 13:54 PST, Alexey Proskuryakov 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-02-24 13:18:36 PST 
I'm not sure why exactly this happens, and it's possible that the tests aren't quite right - but there is a less invasive fix for the Java plug-in that we can use for now.
Comment 1 Alexey Proskuryakov 2010-02-24 13:23:15 PST 
Created attachment 49427 [details]
proposed fix
Comment 2 mitz 2010-02-24 13:37:13 PST 
Comment on attachment 49427 [details]
proposed fix

Can’t DumpRenderTree be modified to use an NSApplication subclass? I don’t think it’s necessary to resort to runtime trickery.
Comment 3 Alexey Proskuryakov 2010-02-24 13:42:09 PST 
Created attachment 49432 [details]
proposed fix
Comment 4 Alexey Proskuryakov 2010-02-24 13:54:59 PST 
Created attachment 49433 [details]
your wish is my command
Comment 5 Alexey Proskuryakov 2010-02-24 13:58:54 PST 
Committed revision 55200.
Comment 6 Simon Fraser (smfr) 2013-07-30 21:18:12 PDT 
This change made DRT run a busyloop while waiting for tests to complete, rather than idling the event loop.
Comment 7 Simon Fraser (smfr) 2013-07-30 21:34:23 PDT 
Fixing via bug 119317.