Bug 119317 - Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
Summary: Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-30 21:31 PDT by Simon Fraser (smfr)
Modified: 2013-08-12 20:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2013-07-30 21:33 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-07-30 21:31:00 PDT 
Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
Comment 1 Simon Fraser (smfr) 2013-07-30 21:33:52 PDT 
Created attachment 207807 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-07 19:12:05 PDT 
Comment on attachment 207807 [details]
Patch

Clearing flags on attachment: 207807

Committed r153811: <http://trac.webkit.org/changeset/153811>
Comment 3 WebKit Commit Bot 2013-08-07 19:12:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Benjamin Poulain 2013-08-11 22:20:17 PDT 
This is really cool!

Why did you need the timeout? Wouldn't CFRunLoopStop(CFRunLoopGetMain()); exit the loop?
Comment 5 Simon Fraser (smfr) 2013-08-12 20:35:20 PDT 
I didn't really need to timeout, but it was a failsafe in case we relied on some other side effect of the old behavior.