Bug 34960 – [Qt] GraphicsLayer: support perspective and 3D transforms

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Noam Rosenthal]

Right now GraphicsLayerQt is limited to 2D transforms only. The first round of 3D functionality would include:
-webkit-perspective
-webkit-perspective-origin
and 3D transforms

this bug does not include preserves-3d and backface-visibility.

[Noam Rosenthal]

Created attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective

Thanks Kim Gronholm from Starlight/Novomok for doing most of the work on this patch

[Ariya Hidayat]

Comment on attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective

Nice work :) LGTM.

[Noam Rosenthal]

Comment on attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective

let's roll...

[WebKit Commit Bot]

Comment on attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective

Rejecting patch 48779 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
pository/webkit/trunk ...
	M	ChangeLog
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/qt/GraphicsLayerQt.cpp
	M	WebKit.pri
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/git/libexec/git-core/git-svn line 558


Full output: http://webkit-commit-queue.appspot.com/results/276227

[Noam Rosenthal]

Created attachment 48907 [details]
Oops, had an "OOPS" in my ChangeLog :)

This has already been reviewed, just need to rubber-stamp it :)

[Ariya Hidayat]

Comment on attachment 48907 [details]
Oops, had an "OOPS" in my ChangeLog :)

r+, cq+ again to land the patch.

[WebKit Commit Bot]

Comment on attachment 48907 [details]
Oops, had an "OOPS" in my ChangeLog :)

Clearing flags on attachment: 48907

Committed r54906: <http://trac.webkit.org/changeset/54906>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ismail Donmez]

Addding these defines to WebKit.pri is not right, --minimal should disable such defines. These should be handled via build-webkit script somehow.

[Noam Rosenthal]

Hmm, you got a point. I'm not a build-system expert but I've created bug 35100 and will look into that.