Bug 34960 - [Qt] GraphicsLayer: support perspective and 3D transforms
Summary: [Qt] GraphicsLayer: support perspective and 3D transforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-02-15 14:02 PST by Noam Rosenthal
Modified: 2010-02-18 07:31 PST (History)
2 users (show)

See Also:


Attachments
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective (9.60 KB, patch)
2010-02-15 14:46 PST, Noam Rosenthal
ariya.hidayat: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Oops, had an "OOPS" in my ChangeLog :) (9.87 KB, patch)
2010-02-17 10:26 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-02-15 14:02:20 PST
Right now GraphicsLayerQt is limited to 2D transforms only. The first round of 3D functionality would include:
-webkit-perspective
-webkit-perspective-origin
and 3D transforms

this bug does not include preserves-3d and backface-visibility.
Comment 1 Noam Rosenthal 2010-02-15 14:46:19 PST
Created attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective

Thanks Kim Gronholm from Starlight/Novomok for doing most of the work on this patch
Comment 2 Ariya Hidayat 2010-02-16 15:45:05 PST
Comment on attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective

Nice work :) LGTM.
Comment 3 Noam Rosenthal 2010-02-16 18:59:38 PST
Comment on attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective

let's roll...
Comment 4 WebKit Commit Bot 2010-02-17 10:21:12 PST
Comment on attachment 48779 [details]
support setChildrenTransform in GraphicsLayerQt, for -webkit-perspective

Rejecting patch 48779 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
pository/webkit/trunk ...
	M	ChangeLog
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/qt/GraphicsLayerQt.cpp
	M	WebKit.pri
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/git/libexec/git-core/git-svn line 558


Full output: http://webkit-commit-queue.appspot.com/results/276227
Comment 5 Noam Rosenthal 2010-02-17 10:26:38 PST
Created attachment 48907 [details]
Oops, had an "OOPS" in my ChangeLog :)

This has already been reviewed, just need to rubber-stamp it :)
Comment 6 Ariya Hidayat 2010-02-17 11:48:25 PST
Comment on attachment 48907 [details]
Oops, had an "OOPS" in my ChangeLog :)

r+, cq+ again to land the patch.
Comment 7 WebKit Commit Bot 2010-02-17 12:08:13 PST
Comment on attachment 48907 [details]
Oops, had an "OOPS" in my ChangeLog :)

Clearing flags on attachment: 48907

Committed r54906: <http://trac.webkit.org/changeset/54906>
Comment 8 WebKit Commit Bot 2010-02-17 12:08:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Ismail Donmez 2010-02-18 02:01:43 PST
Addding these defines to WebKit.pri is not right, --minimal should disable such defines. These should be handled via build-webkit script somehow.
Comment 10 Noam Rosenthal 2010-02-18 07:31:59 PST
Hmm, you got a point. I'm not a build-system expert but I've created bug 35100 and will look into that.