Bug 35100 - [Qt] ENABLE_3D_RENDERING should be optional
Summary: [Qt] ENABLE_3D_RENDERING should be optional
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-02-18 07:31 PST by Noam Rosenthal
Modified: 2010-02-20 12:30 PST (History)
1 user (show)

See Also:

Attachments
ENABLE_3D_RENDERING moved to be a normal feature (2.17 KB, patch)
2010-02-18 08:51 PST, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-02-18 07:31:11 PST 
for example, building webkit with --minimal should disable them.
Comment 1 Noam Rosenthal 2010-02-18 08:51:34 PST 
Created attachment 49020 [details]
ENABLE_3D_RENDERING moved to be a normal feature

This seems to rectify the problem for ENABLE_3D_RENDERING (moved to be a normal feature, rather than a forced define).
However, I'm not sure how to do that for WTF_ENABLE_ACCELERATED_COMPOSITING, which doesn't appear as a "feature". Help would be appreciated.
Comment 2 Laszlo Gombos 2010-02-19 12:19:45 PST 
The patch looks good to me, if we only try to restrict it to ENABLE_3D_RENDERING. Noam, can you change the bug title and ChangeLog accordingly ? 

I think we should open another bug for ACCELERATED_COMPOSITING as it will likely involve changes to other ports as well, not just for QtWebKit. In general USE(xx) flags are not meant to be turn on/off optionally at build time within a given WebKit port.
Comment 3 Laszlo Gombos 2010-02-20 12:10:23 PST 
Comment on attachment 49020 [details]
ENABLE_3D_RENDERING moved to be a normal feature

LGTM, r+. I will update the title in the ChangeLogs as well during a manual commit.
Comment 4 Laszlo Gombos 2010-02-20 12:30:24 PST 
Comment on attachment 49020 [details]
ENABLE_3D_RENDERING moved to be a normal feature

Committed as http://trac.webkit.org/changeset/55056.