Bug 34793 - [Qt] QScriptValue::toBool problem
Summary: [Qt] QScriptValue::toBool problem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jędrzej Nowacki
URL:
Keywords: Qt
Depends on:
Blocks: 31863
  Show dependency tree / graph
 
Reported: 2010-02-10 04:02 PST by Jędrzej Nowacki
Modified: 2010-02-10 09:55 PST (History)
1 user (show)

See Also:

Attachments
Fix v1 (17.43 KB, patch)
2010-02-10 04:08 PST, Jędrzej Nowacki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-02-10 04:02:08 PST 
QScriptValue::toBool (and toBoolean) returns a bad value for a numbers like 0, NaN and for an empty strings.
Comment 1 Jędrzej Nowacki 2010-02-10 04:08:54 PST 
Created attachment 48485 [details]
Fix v1
Comment 2 Simon Hausmann 2010-02-10 04:26:49 PST 
Comment on attachment 48485 [details]
Fix v1

LGTM
Comment 3 WebKit Commit Bot 2010-02-10 09:55:18 PST 
Comment on attachment 48485 [details]
Fix v1

Clearing flags on attachment: 48485

Committed r54605: <http://trac.webkit.org/changeset/54605>
Comment 4 WebKit Commit Bot 2010-02-10 09:55:23 PST 
All reviewed patches have been landed.  Closing bug.