Bug 34775 - Black Highlight when selecting certain elements
Summary: Black Highlight when selecting certain elements
Status: RESOLVED DUPLICATE of bug 38523
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
Keywords: Qt
Depends on:
Reported: 2010-02-09 12:55 PST by Aaron Conran
Modified: 2010-05-18 02:03 PDT (History)
4 users (show)

See Also:

Screenshot. (109.64 KB, image/png)
2010-02-09 12:55 PST, Aaron Conran
no flags Details
Naive Patch (493 bytes, patch)
2010-02-11 20:31 PST, Nick Young
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Conran 2010-02-09 12:55:08 PST
Created attachment 48439 [details]

Certain elements will highlight with a black background instead of the default.

This can completely mask elements and make them unusable until unselected.

For a simple reproducible example, compile the "Fancy Browser Example" shipped with Qt.

Navigate to:

Do a drag selection from the text above and go down. 

Certain elements will highlight with black instead of the default.
Comment 1 Aaron Conran 2010-02-09 12:56:24 PST
It's also worth noting that this example works fine in Chrome and Safari.
Comment 2 Nick Young 2010-02-11 20:31:30 PST
Created attachment 48617 [details]
Naive Patch

This naive patch solves the problem for me.
However, It seems to be indicative of a deeper problem where we have a brush with an invalid color that does not have a style == Qt::NoBrush.
Comment 3 Kenneth Rohde Christiansen 2010-02-12 04:28:32 PST
Ah I remember that we had such a similar issue before. Do you remember the details Simon?
Comment 4 Ariya Hidayat 2010-03-04 11:20:50 PST
I guess this is because of my commit: http://trac.webkit.org/changeset/37421

The optimization does not take into account that the color could be bogus.

The patch from Nick looks good to solve this problem.
Comment 5 Ariya Hidayat 2010-03-04 11:30:47 PST
> I guess this is because of my commit: http://trac.webkit.org/changeset/37421

False alarm. Excluding the optimization still shows the same behaviour.

Nick: if you include some ChangeLog, then we can land your patch.
Comment 6 Tor Arne Vestbø 2010-03-10 06:32:15 PST
Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs


  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit


  - Add the keyword 'Qt' to signal that it's a Qt-related bug

Comment 7 Ariya Hidayat 2010-05-17 02:16:03 PDT
Fixed by the commit http://trac.webkit.org/changeset/58949
Comment 8 Simon Hausmann 2010-05-18 02:03:57 PDT

*** This bug has been marked as a duplicate of bug 38523 ***