Bug 34695 - Add modified version of CSS2.1 test suite for paged media
Summary: Add modified version of CSS2.1 test suite for paged media
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Shinichiro Hamaji
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-07 22:46 PST by Shinichiro Hamaji
Modified: 2010-02-09 01:46 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (20.84 KB, patch)
2010-02-07 22:48 PST, Shinichiro Hamaji 		darin: review+
Details | Formatted Diff | Diff
diff from the original tests (8.31 KB, patch)
2010-02-07 22:56 PST, Shinichiro Hamaji 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-02-07 22:46:38 PST 
W3C recently has released CSS2.1 Conformance Test Suite. The release adds some tests for paged media. As adding unmodified version of them into LayoutTests/css2.1 directory doesn't make sense at all, let's modify them using layoutTestController.pageNumberForElementById and add them in our repository.

http://www.w3.org/Style/CSS/Test/CSS2.1/20100127/html4/chapter-13.htm
Comment 1 Shinichiro Hamaji 2010-02-07 22:48:13 PST 
Created attachment 48318 [details]
Patch v1
Comment 2 Shinichiro Hamaji 2010-02-07 22:51:37 PST 
Notes:

- page-break-inside-000 is failing test because this feature is unimplemented.
- We can remove changes for win/Skipped and qt/Skipped if Bug 34570 and Bug 34573 are closed.
- See README.txt to know why I didn't add page-break-before-003 for now.
Comment 3 Shinichiro Hamaji 2010-02-07 22:56:08 PST 
Created attachment 48319 [details]
diff from the original tests

FYI, this is the diff from the original CSS2.1 test suite. Here is the summary of my changes:

- eliminate tabs
- added dumpAsText() call
- added test() function and implement it
- added id attributes for elements in question
- added <div id="results"> to report the test results
Comment 4 Darin Adler 2010-02-08 09:50:40 PST 
Comment on attachment 48318 [details]
Patch v1

> +This is the modified version of W3C's CSS2.1 test suite.

Modified how? Something needs to say specifically. Is every single test modified? Is it done with a script? What should be done in future if the W3C's test suite is improved?

More tests=good

r=me
Comment 5 Eric Seidel (no email) 2010-02-08 11:21:33 PST 
Attachment 48318 [details] was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit.
Comment 6 Shinichiro Hamaji 2010-02-09 01:46:47 PST 
> Modified how? Something needs to say specifically. Is every single test
> modified? Is it done with a script? What should be done in future if the W3C's
> test suite is improved?

Thanks for the review! I've modified the README.txt file so it has descriptions which I wrote in the description of this bug and comment #3. I landed this as r54538.