RESOLVED FIXED Bug 34695
Add modified version of CSS2.1 test suite for paged media 
https://bugs.webkit.org/show_bug.cgi?id=34695
Summary Add modified version of CSS2.1 test suite for paged media
Shinichiro Hamaji
Reported 2010-02-07 22:46:38 PST
W3C recently has released CSS2.1 Conformance Test Suite. The release adds some tests for paged media. As adding unmodified version of them into LayoutTests/css2.1 directory doesn't make sense at all, let's modify them using layoutTestController.pageNumberForElementById and add them in our repository. http://www.w3.org/Style/CSS/Test/CSS2.1/20100127/html4/chapter-13.htm
Attachments
Patch v1 (20.84 KB, patch)
2010-02-07 22:48 PST, Shinichiro Hamaji 		darin: review+
DetailsFormatted DiffDiff
diff from the original tests (8.31 KB, patch)
2010-02-07 22:56 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-02-07 22:48:13 PST
Created attachment 48318 [details] Patch v1
Shinichiro Hamaji
Comment 2 2010-02-07 22:51:37 PST
Notes: - page-break-inside-000 is failing test because this feature is unimplemented. - We can remove changes for win/Skipped and qt/Skipped if Bug 34570 and Bug 34573 are closed. - See README.txt to know why I didn't add page-break-before-003 for now.
Shinichiro Hamaji
Comment 3 2010-02-07 22:56:08 PST
Created attachment 48319 [details] diff from the original tests FYI, this is the diff from the original CSS2.1 test suite. Here is the summary of my changes: - eliminate tabs - added dumpAsText() call - added test() function and implement it - added id attributes for elements in question - added <div id="results"> to report the test results
Darin Adler
Comment 4 2010-02-08 09:50:40 PST
Comment on attachment 48318 [details] Patch v1 > +This is the modified version of W3C's CSS2.1 test suite. Modified how? Something needs to say specifically. Is every single test modified? Is it done with a script? What should be done in future if the W3C's test suite is improved? More tests=good r=me
Eric Seidel (no email)
Comment 5 2010-02-08 11:21:33 PST
Attachment 48318 [details] was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit.
Shinichiro Hamaji
Comment 6 2010-02-09 01:46:47 PST
> Modified how? Something needs to say specifically. Is every single test > modified? Is it done with a script? What should be done in future if the W3C's > test suite is improved? Thanks for the review! I've modified the README.txt file so it has descriptions which I wrote in the description of this bug and comment #3. I landed this as r54538.
Note You need to log in before you can comment on or make changes to this bug.