Bug 34570 - [Win] Implement test functions for printing
Summary: [Win] Implement test functions for printing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-02-04 03:28 PST by Shinichiro Hamaji
Modified: 2010-02-17 20:19 PST (History)
5 users (show)

See Also:

Patch v1 (5.98 KB, patch)
2010-02-04 03:32 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff
Patch v2 (7.47 KB, patch)
2010-02-16 00:51 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-02-04 03:28:27 PST
This was added in Bug 33840.
Comment 1 Shinichiro Hamaji 2010-02-04 03:32:25 PST
Created attachment 48127 [details]
Patch v1
Comment 2 Shinichiro Hamaji 2010-02-16 00:51:09 PST
Renaming title: "[Win] Implement layoutTestController.pageNumberForElementById" => "[Win] Implement test functions for printing" .

As the implementation of layoutTestController.numberOfPages added in Bug 34699 is similar to layoutTestController.pageNumberForElementById, it would make sense to implement them at once.
Comment 3 Shinichiro Hamaji 2010-02-16 00:51:32 PST
Created attachment 48793 [details]
Patch v2
Comment 4 Eric Seidel (no email) 2010-02-17 15:50:25 PST
Comment on attachment 48793 [details]
Patch v2

Adam or Steve are your best reviewers here, but this looks sane to me.
Comment 5 Shinichiro Hamaji 2010-02-17 18:42:14 PST
Comment on attachment 48793 [details]
Patch v2

Clearing flags on attachment: 48793

Committed r54921: <http://trac.webkit.org/changeset/54921>
Comment 6 Shinichiro Hamaji 2010-02-17 18:42:22 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Shinichiro Hamaji 2010-02-17 19:35:04 PST
Hmm... My change broke the build.


I guess it happened because the change for IWebFramePrivate.idl wasn't handled and just re-generating WebKitBuild/include/WebKit/WebKit.h will fix the build. Are there any way to re-generate the file?
Comment 8 Shinichiro Hamaji 2010-02-17 20:19:17 PST
Committed r54922: <http://trac.webkit.org/changeset/54922>