Bug 34592 - [Qt] QScriptValue::toNumber() is broken
Summary: [Qt] QScriptValue::toNumber() is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jędrzej Nowacki
URL:
Keywords: Qt
Depends on:
Blocks: 31863
  Show dependency treegraph
 
Reported: 2010-02-04 08:03 PST by Jędrzej Nowacki
Modified: 2010-02-09 18:36 PST (History)
2 users (show)

See Also:


Attachments
use cases (980 bytes, text/plain)
2010-02-04 08:03 PST, Jędrzej Nowacki
no flags Details
fix v1 (11.19 KB, patch)
2010-02-04 08:37 PST, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff
Fix v2 (11.18 KB, patch)
2010-02-09 02:48 PST, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-02-04 08:03:53 PST
Created attachment 48144 [details]
use cases

There are different use cases for which the toNumber() returns incorrect value. 
The use cases in the attachment.
Comment 1 Jędrzej Nowacki 2010-02-04 08:37:43 PST
Created attachment 48147 [details]
fix v1
Comment 2 WebKit Review Bot 2010-02-04 08:40:46 PST
Attachment 48147 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Ignoring "JavaScriptCore/qt/api/qscriptvalue_p.h": this file is exempt from the style guide.
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:76:  toNumber_data is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:124:  toNumber_initData is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:125:  toNumber_makeData is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:126:  toNumber_test is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 4


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jędrzej Nowacki 2010-02-09 02:48:19 PST
Created attachment 48397 [details]
Fix v2
Comment 4 WebKit Commit Bot 2010-02-09 18:36:45 PST
Comment on attachment 48397 [details]
Fix v2

Clearing flags on attachment: 48397

Committed r54579: <http://trac.webkit.org/changeset/54579>
Comment 5 WebKit Commit Bot 2010-02-09 18:36:50 PST
All reviewed patches have been landed.  Closing bug.