The current basic-touch-events test mixes both single and multi touch tests, and assumes the touch events are sent synchronously from the platform to WebCore. I'd like to refactor this test so that: 1) We test single and multi touch in two separate tests 2) The tests run in an asynchronous manner These changes will enable the tests to run properly on Android where touch events are passed asynchronously from the platform to WebCore and there is not support for multi touch.
Created attachment 47932 [details] Proposed patch updating the tests.
Is there anyone working on touch events from Apple's side of thing who might also be a good reviewer for this? CCing ddkilzer as he knows iphone stuff.
ping?
Comment on attachment 47932 [details] Proposed patch updating the tests. Nice cleanup! Sorry for the delay in review :(
Comment on attachment 47932 [details] Proposed patch updating the tests. Thanks for the review Simon!
Comment on attachment 47932 [details] Proposed patch updating the tests. Rejecting patch 47932 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Hausmann', '--force']" exit_code: 2 cp: LayoutTests/fast/events/script-tests/basic-touch-events.js: No such file or directory Failed to copy LayoutTests/fast/events/script-tests/basic-touch-events.js LayoutTests/fast/events/script-tests/basic-single-touch-events.js. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 455, <> line 1664. Full output: http://webkit-commit-queue.appspot.com/results/268582
Ah, the tests have been moved out under me. I'll upload this manually.
Landed manually as r54817.