Bug 34476 - Refactor and split up basic-touch-events test
Summary: Refactor and split up basic-touch-events test
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ben Murdoch
Depends on:
Blocks: 32485 34585
  Show dependency treegraph
Reported: 2010-02-02 07:46 PST by Ben Murdoch
Modified: 2010-02-16 03:18 PST (History)
6 users (show)

See Also:

Proposed patch updating the tests. (62.70 KB, patch)
2010-02-02 08:09 PST, Ben Murdoch
hausmann: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2010-02-02 07:46:54 PST
The current basic-touch-events test mixes both single and multi touch tests, and assumes the touch events are sent synchronously from the platform to WebCore.

I'd like to refactor this test so that:
1) We test single and multi touch in two separate tests
2) The tests run in an asynchronous manner

These changes will enable the tests to run properly on Android where touch events are passed asynchronously from the platform to WebCore and there is not support for multi touch.
Comment 1 Ben Murdoch 2010-02-02 08:09:09 PST
Created attachment 47932 [details]
Proposed patch updating the tests.
Comment 2 Eric Seidel (no email) 2010-02-04 14:46:26 PST
Is there anyone working on touch events from Apple's side of thing who might also be a good reviewer for this?  CCing ddkilzer as he knows iphone stuff.
Comment 3 Ben Murdoch 2010-02-11 07:52:20 PST
Comment 4 Simon Hausmann 2010-02-15 07:10:53 PST
Comment on attachment 47932 [details]
Proposed patch updating the tests.

Nice cleanup! Sorry for the delay in review :(
Comment 5 Ben Murdoch 2010-02-15 07:30:33 PST
Comment on attachment 47932 [details]
Proposed patch updating the tests.

Thanks for the review Simon!
Comment 6 WebKit Commit Bot 2010-02-15 07:44:45 PST
Comment on attachment 47932 [details]
Proposed patch updating the tests.

Rejecting patch 47932 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Hausmann', '--force']" exit_code: 2
cp: LayoutTests/fast/events/script-tests/basic-touch-events.js: No such file or directory
Failed to copy LayoutTests/fast/events/script-tests/basic-touch-events.js LayoutTests/fast/events/script-tests/basic-single-touch-events.js. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 455, <> line 1664.

Full output: http://webkit-commit-queue.appspot.com/results/268582
Comment 7 Ben Murdoch 2010-02-15 07:50:26 PST
Ah, the tests have been moved out under me. I'll upload this manually.
Comment 8 Ben Murdoch 2010-02-16 03:18:54 PST
Landed manually as r54817.