Bug 34444 – Crash in Safari opening new tabs/windows to "same page"

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Brady Eidson]

Set Safari to open new tabs/windows to the same page.

Run ToT WebKit, visit any single page in a new window, then open a new tab/window.

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x00000000000000d0
Crashed Thread:  0  Dispatch queue: com.apple.main-thread

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x0000000100a71b42 WebCore::FrameLoader::loadItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 50
1   com.apple.WebCore             	0x0000000100e85dbb WebCore::HistoryController::recursiveGoToItem(WebCore::HistoryItem*, WebCore::HistoryItem*, WebCore::FrameLoadType) + 363
2   com.apple.WebCore             	0x0000000100a71a3d WebCore::Page::goToItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 189
3   com.apple.WebKit              	0x0000000100643dde -[WebView(WebPrivate) _loadBackForwardListFromOtherView:] + 382
4   Safari                    	0x0000000100097226 0x100000000 + 619046
5   com.apple.AppKit              	0x00007fff80ca909a -[NSApplication sendAction:to:from:] + 95
6   Safari                    	0x000000010004e4b3 0x100000000 + 320691
7   com.apple.AppKit              	0x00007fff80ccd602 -[NSMenuItem _corePerformAction] + 365
8   com.apple.AppKit              	0x00007fff80ccd36c -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 121
9   com.apple.AppKit              	0x00007fff80cb3009 -[NSMenu performKeyEquivalent:] + 272
10  com.apple.AppKit              	0x00007fff80cb1db1 -[NSApplication _handleKeyEquivalent:] + 559
11  com.apple.AppKit              	0x00007fff80b829e1 -[NSApplication sendEvent:] + 3630
12  Safari                    	0x0000000100032aa2 0x100000000 + 207522
13  com.apple.AppKit              	0x00007fff80b19796 -[NSApplication run] + 474
14  com.apple.AppKit              	0x00007fff80b12468 NSApplicationMain + 364
15  Safari                    	0x0000000100002224 0x100000000 + 8740

I have a patch coming to plug two places where the current history item is not null checked.

[Brady Eidson]

In Radar as <rdar://problem/7593857>

[Brady Eidson]

Created attachment 47863 [details]
Patch v1

[WebKit Review Bot]

Attachment 47863 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/loader/FrameLoader.cpp:3822:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

*** Bug 34443 has been marked as a duplicate of this bug. ***

[Brady Eidson]

Comment on attachment 47863 [details]
Patch v1

sorry, forgot to fill out changelogs (and will fix the style-check issue)

[Brady Eidson]

Created attachment 47865 [details]
v2 - Fill out changelogs and fix style failure

[Eric Seidel (no email)]

Attachment 47865 [details] was posted by a committer and has review+, assigning to Brady Eidson for commit.

[Brady Eidson]

Yup, landed earlier in http://trac.webkit.org/changeset/54145