[chromium] Add allowPlugins callback to allow per-site enabling of plugins
Created attachment 47151 [details] Patch
Comment on attachment 47151 [details] Patch Looks sane. Sad we don't have testing for this sort of thing.
Fishd, you might want to look at this patch because it touches the WebKit API.
Adam, why should this be exempt from the "don't change FrameLoader without a test" rule?
Comment on attachment 47151 [details] Patch Clearing flags on attachment: 47151 Committed r53681: <http://trac.webkit.org/changeset/53681>
All reviewed patches have been landed. Closing bug.
(In reply to comment #3) > Fishd, you might want to look at this patch because it touches the WebKit API. LGTM
Comment on attachment 47151 [details] Patch > +++ b/WebKit/chromium/public/WebFrameClient.h > @@ -80,6 +80,8 @@ public: > // This frame is about to be closed. > virtual void willClose(WebFrame*) { } > > + // Controls whether plugins are allowed for this frame. > + virtual bool allowPlugins(WebFrame*, bool enabledPerSettings) { return enabledPerSettings; } > > // Load commands ------------------------------------------------------- nit: it would have been nice to preserve the two new lines above the comment separator.
> nit: it would have been nice to preserve the two new lines above the comment > separator. Fixenated. http://trac.webkit.org/changeset/53683
> Adam, why should this be exempt from the "don't change FrameLoader without a > test" rule? Good question! It shouldn't be. Thanks for ruining my weekend. :)
Bug filed for a test: https://bugs.webkit.org/show_bug.cgi?id=33991