Bug 33974 - [chromium] Add allowPlugins callback to allow per-site enabling of plugins
Summary: [chromium] Add allowPlugins callback to allow per-site enabling of plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-21 15:05 PST by Adam Barth
Modified: 2010-01-21 23:53 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.72 KB, patch)
2010-01-21 15:06 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-01-21 15:05:26 PST
[chromium] Add allowPlugins callback to allow per-site enabling of plugins
Comment 1 Adam Barth 2010-01-21 15:06:50 PST
Created attachment 47151 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-01-21 16:44:22 PST
Comment on attachment 47151 [details]
Patch

Looks sane.  Sad we don't have testing for this sort of thing.
Comment 3 Adam Barth 2010-01-21 17:06:52 PST
Fishd, you might want to look at this patch because it touches the WebKit API.
Comment 4 Sam Weinig 2010-01-21 17:56:31 PST
Adam, why should this be exempt from the "don't change FrameLoader without a test" rule?
Comment 5 WebKit Commit Bot 2010-01-21 23:11:30 PST
Comment on attachment 47151 [details]
Patch

Clearing flags on attachment: 47151

Committed r53681: <http://trac.webkit.org/changeset/53681>
Comment 6 WebKit Commit Bot 2010-01-21 23:11:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Fisher (:fishd, Google) 2010-01-21 23:31:49 PST
(In reply to comment #3)
> Fishd, you might want to look at this patch because it touches the WebKit API.

LGTM
Comment 8 Darin Fisher (:fishd, Google) 2010-01-21 23:33:50 PST
Comment on attachment 47151 [details]
Patch

> +++ b/WebKit/chromium/public/WebFrameClient.h
> @@ -80,6 +80,8 @@ public:
>      // This frame is about to be closed.
>      virtual void willClose(WebFrame*) { }
>  
> +    // Controls whether plugins are allowed for this frame.
> +    virtual bool allowPlugins(WebFrame*, bool enabledPerSettings) { return enabledPerSettings; }
>  
>      // Load commands -------------------------------------------------------

nit: it would have been nice to preserve the two new lines above the comment
separator.
Comment 9 Adam Barth 2010-01-21 23:49:17 PST
> nit: it would have been nice to preserve the two new lines above the comment
> separator.

Fixenated.  http://trac.webkit.org/changeset/53683
Comment 10 Adam Barth 2010-01-21 23:50:51 PST
> Adam, why should this be exempt from the "don't change FrameLoader without a
> test" rule?

Good question!  It shouldn't be.  Thanks for ruining my weekend.  :)
Comment 11 Adam Barth 2010-01-21 23:53:55 PST
Bug filed for a test: https://bugs.webkit.org/show_bug.cgi?id=33991