RESOLVED FIXED Bug 33991
Add a test for FrameLoaderClient::allowPlugins 
https://bugs.webkit.org/show_bug.cgi?id=33991
Summary Add a test for FrameLoaderClient::allowPlugins
Adam Barth
Reported 2010-01-21 23:53:31 PST
Sam pointed out that I modified FrameLoader.cpp without making a test: http://trac.webkit.org/changeset/53681 I owe the project a test. I have no idea how to test that change, but I'll find a way.
Attachments
Patch (8.64 KB, patch)
2011-08-02 08:04 PDT, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2010-01-29 00:49:09 PST
https://bugs.webkit.org/show_bug.cgi?id=34314 is similar, but for allowImages. The same testing approach should work for both.
Adam Barth
Comment 2 2011-05-27 17:22:47 PDT
jochen added some code recently to make testing these feature easier.
jochen
Comment 3 2011-05-28 10:03:40 PDT
I've added a layout test for allowStorage in https://bugs.webkit.org/show_bug.cgi?id=61581
jochen
Comment 4 2011-08-02 08:04:48 PDT
Created attachment 102653 [details] Patch
jochen
Comment 5 2011-08-02 08:05:11 PDT
Adam, please take a look
Adam Barth
Comment 6 2011-08-02 11:56:15 PDT
Comment on attachment 102653 [details] Patch Thanks!
WebKit Review Bot
Comment 7 2011-08-02 13:01:00 PDT
Comment on attachment 102653 [details] Patch Clearing flags on attachment: 102653 Committed r92219: <http://trac.webkit.org/changeset/92219>
WebKit Review Bot
Comment 8 2011-08-02 13:01:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.