Bug 33991 - Add a test for FrameLoaderClient::allowPlugins
Summary: Add a test for FrameLoaderClient::allowPlugins
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2010-01-21 23:53 PST by Adam Barth
Modified: 2011-08-02 13:01 PDT (History)
5 users (show)

See Also:

Patch (8.64 KB, patch)
2011-08-02 08:04 PDT, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-01-21 23:53:31 PST
Sam pointed out that I modified FrameLoader.cpp without making a test:


I owe the project a test.  I have no idea how to test that change, but I'll find a way.
Comment 1 Darin Fisher (:fishd, Google) 2010-01-29 00:49:09 PST
https://bugs.webkit.org/show_bug.cgi?id=34314 is similar, but for allowImages.  The same testing approach should work for both.
Comment 2 Adam Barth 2011-05-27 17:22:47 PDT
jochen added some code recently to make testing these feature easier.
Comment 3 jochen 2011-05-28 10:03:40 PDT
I've added a layout test for allowStorage in https://bugs.webkit.org/show_bug.cgi?id=61581
Comment 4 jochen 2011-08-02 08:04:48 PDT
Created attachment 102653 [details]
Comment 5 jochen 2011-08-02 08:05:11 PDT
Adam, please take a look
Comment 6 Adam Barth 2011-08-02 11:56:15 PDT
Comment on attachment 102653 [details]

Comment 7 WebKit Review Bot 2011-08-02 13:01:00 PDT
Comment on attachment 102653 [details]

Clearing flags on attachment: 102653

Committed r92219: <http://trac.webkit.org/changeset/92219>
Comment 8 WebKit Review Bot 2011-08-02 13:01:05 PDT
All reviewed patches have been landed.  Closing bug.