Bug 33958 – [Android] JavaField and JavaArray use JSC-specific types

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Steve Block]

WebCore/bridge/jni/JNIBridge.[cpp|h] provides a number of classes.
Of these, JavaField and JavaArray use JSC-specific types.
This causes problems on Android, where we can build with JSC or V8.

These JSC-specific classes should be moved out of JNIBridge.[cpp|h] to allow the file to be used with both JSC and V8.

[Steve Block]

Created attachment 47197 [details]
Patch

[WebKit Review Bot]

Attachment 47197 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Traceback (most recent call last):
  File "WebKitTools/Scripts/check-webkit-style", line 94, in <module>
    main()
  File "WebKitTools/Scripts/check-webkit-style", line 87, in main
    style_checker.check_patch(patch)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch
    self.check_file(file_path, handle_style_error=error_for_patch)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file
    process_file(processor, file_path, handle_style_error)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file
    processor.process(lines)
AttributeError: 'NoneType' object has no attribute 'process'


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 47197 [details]
Patch

Ok.  I didn't prove to myself that this was just moving code, but I believe you when you say it is.

You even get out of fixing the style nits because the style bot was down when you uploaded your patch.  :)

[Steve Block]

Comment on attachment 47197 [details]
Patch

I've checked that the style is good. This patch only moves code from JNIBridge.[cpp|h] and the style in those files was fixed in Bug 33914

[WebKit Commit Bot]

Comment on attachment 47197 [details]
Patch

Clearing flags on attachment: 47197

Committed r53849: <http://trac.webkit.org/changeset/53849>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.