Bug 33839 - Style in WebCore/bridge/Bridge needs fixing
Summary: Style in WebCore/bridge/Bridge needs fixing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks: 33801
  Show dependency tree / graph
 
Reported: 2010-01-19 03:52 PST by Steve Block
Modified: 2010-01-20 03:49 PST (History)
5 users (show)

See Also:

Attachments
Patch 1 for Bug 33839 (12.29 KB, patch)
2010-01-19 06:05 PST, Steve Block 		levin: review+
steveblock: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-19 03:52:22 PST 
Style in WebCore/bridge/Bridge needs fixing

See Bug 33801, which this bug blocks
Comment 1 Steve Block 2010-01-19 06:05:45 PST 
Created attachment 46902 [details]
Patch 1 for Bug 33839
Comment 2 Steve Block 2010-01-20 03:35:29 PST 
Comment on attachment 46902 [details]
Patch 1 for Bug 33839

This patch has been in the commit queue for over 12 hours but keeps getting pushed down the queue by other, more recent patches.

Giving up and landing manually.
Comment 3 Steve Block 2010-01-20 03:39:21 PST 
Landed as http://trac.webkit.org/changeset/53541

Closing bug as resolved
Comment 4 Eric Seidel (no email) 2010-01-20 03:41:20 PST 
Well, that and the bots have been red much of the day.  bug 33893 is our latest blocker.

the commit-queue's landing speed greatly regressed with http://trac.webkit.org/changeset/52764

But our biggest problem is just that the webkit.org bots are red all the time. :(

Sorry the cq didn't work for you.  Hopefully webkit-patch land-from-bug was at least helpful.
Comment 5 Steve Block 2010-01-20 03:49:27 PST 
> Well, that and the bots have been red much of the day.  bug 33893 is our latest
> blocker.
It's true that the bots are often red, but a number of patches have been landed in that time.

> Sorry the cq didn't work for you.  Hopefully webkit-patch land-from-bug was at
> least helpful.
No problem. Just makes me more keen to fix Bug 33395!