Bug 33801 - WebCore/bridge/runtime.[cpp|h] should be renamed
Summary: WebCore/bridge/runtime.[cpp|h] should be renamed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on: 33839
Blocks: 33712 33589
  Show dependency treegraph
 
Reported: 2010-01-18 07:49 PST by Steve Block
Modified: 2010-01-20 03:40 PST (History)
3 users (show)

See Also:


Attachments
Patch 1 for Bug 33801 (51.66 KB, patch)
2010-01-18 09:03 PST, Steve Block
no flags Details | Formatted Diff | Diff
Patch 2 for Bug 33801 (52.08 KB, patch)
2010-01-18 09:41 PST, Steve Block
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-18 07:49:47 PST
WebCore/bridge/runtime.[cpp|h] should be renamed. This is part of the renaming of numerous files in WebCore/bridge. See Bug 33712, which this bug blocks.
Comment 1 Steve Block 2010-01-18 09:03:45 PST
Created attachment 46827 [details]
Patch 1 for Bug 33801

Renames runtime.[cpp|h] to Bridge.[cpp|h]
Comment 2 WebKit Review Bot 2010-01-18 09:09:50 PST
Attachment 46827 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bridge/testbindings.cpp:23:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebCore/bridge/Bridge.h:124:  _rootObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bridge/Bridge.h:140:  _rootObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Skipping input 'WebCore/bridge/runtime.cpp': Can't open for reading
WebCore/bridge/testqtbindings.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Skipping input 'WebCore/bridge/runtime.h': Can't open for reading
Total errors found: 4


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Steve Block 2010-01-18 09:12:57 PST
(In reply to comment #2)
> Attachment 46827 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebCore/bridge/testbindings.cpp:23:  Found other header before a header this
> file implements. Should be: config.h, primary header, blank line, and then
> alphabetically sorted.  [build/include_order] [4]
This seems to be a false positive.

> WebCore/bridge/Bridge.h:124:  _rootObject is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming] [4]
> WebCore/bridge/Bridge.h:140:  _rootObject is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming] [4]
Will fix style in moved code in a separate patch.
Comment 4 WebKit Review Bot 2010-01-18 09:15:58 PST
Attachment 46827 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/198037
Comment 5 Steve Block 2010-01-18 09:41:17 PST
Created attachment 46830 [details]
Patch 2 for Bug 33801

Fixes qt build
Comment 6 WebKit Review Bot 2010-01-18 09:45:41 PST
Attachment 46830 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bridge/testbindings.cpp:23:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebCore/bridge/Bridge.h:124:  _rootObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bridge/Bridge.h:140:  _rootObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Skipping input 'WebCore/bridge/runtime.cpp': Can't open for reading
WebCore/bridge/testqtbindings.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Skipping input 'WebCore/bridge/runtime.h': Can't open for reading
Total errors found: 4


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Adam Barth 2010-01-18 09:56:27 PST
Comment on attachment 46830 [details]
Patch 2 for Bug 33801

ok
Comment 8 WebKit Review Bot 2010-01-18 10:16:44 PST
Attachment 46830 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/199035
Comment 9 Steve Block 2010-01-19 03:53:19 PST
Fixed qt build problem and landed manually as
http://trac.webkit.org/changeset/53464

Have opened Bug 33839 to fix style in moved code.
Comment 10 Adam Barth 2010-01-20 03:13:19 PST
> This seems to be a false positive.

Filed: https://bugs.webkit.org/show_bug.cgi?id=33891
Comment 11 Steve Block 2010-01-20 03:40:21 PST
Style is now fixed

Closing bug as resolved