Bug 33801 – WebCore/bridge/runtime.[cpp|h] should be renamed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Steve Block]

WebCore/bridge/runtime.[cpp|h] should be renamed. This is part of the renaming of numerous files in WebCore/bridge. See Bug 33712, which this bug blocks.

[Steve Block]

Created attachment 46827 [details]
Patch 1 for Bug 33801

Renames runtime.[cpp|h] to Bridge.[cpp|h]

[WebKit Review Bot]

Attachment 46827 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bridge/testbindings.cpp:23:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebCore/bridge/Bridge.h:124:  _rootObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bridge/Bridge.h:140:  _rootObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Skipping input 'WebCore/bridge/runtime.cpp': Can't open for reading
WebCore/bridge/testqtbindings.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Skipping input 'WebCore/bridge/runtime.h': Can't open for reading
Total errors found: 4


If any of these errors are false positives, please file a bug against check-webkit-style.

[Steve Block]

(In reply to comment #2)
> Attachment 46827 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebCore/bridge/testbindings.cpp:23:  Found other header before a header this
> file implements. Should be: config.h, primary header, blank line, and then
> alphabetically sorted.  [build/include_order] [4]
This seems to be a false positive.

> WebCore/bridge/Bridge.h:124:  _rootObject is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming] [4]
> WebCore/bridge/Bridge.h:140:  _rootObject is incorrectly named. Don't use
> underscores in your identifier names.  [readability/naming] [4]
Will fix style in moved code in a separate patch.

[WebKit Review Bot]

Attachment 46827 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/198037

[Steve Block]

Created attachment 46830 [details]
Patch 2 for Bug 33801

Fixes qt build

[WebKit Review Bot]

Attachment 46830 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bridge/testbindings.cpp:23:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebCore/bridge/Bridge.h:124:  _rootObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bridge/Bridge.h:140:  _rootObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Skipping input 'WebCore/bridge/runtime.cpp': Can't open for reading
WebCore/bridge/testqtbindings.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Skipping input 'WebCore/bridge/runtime.h': Can't open for reading
Total errors found: 4


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 46830 [details]
Patch 2 for Bug 33801

ok

[WebKit Review Bot]

Attachment 46830 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/199035

[Steve Block]

Fixed qt build problem and landed manually as
http://trac.webkit.org/changeset/53464

Have opened Bug 33839 to fix style in moved code.

[Adam Barth]

> This seems to be a false positive.

Filed: https://bugs.webkit.org/show_bug.cgi?id=33891

[Steve Block]

Style is now fixed

Closing bug as resolved