Bug 33834 – [Qt] REGRESSION (r53450): 3 tests fail on Qt bot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

Unfortunately I can't find the original bug for r49567, so I filed a new one.

r49567 reverted by r53450. This revert cause 3 tests fail on Qt bot:
css1/box_properties/acid_test.html - wasn't modified by r53450
css1/font_properties/font.html
fast/forms/textarea-scrollbar-height.html - wasn't modified by r53450

detailed results: http://build.webkit.org/results/Qt%20Linux%20Release/r53460%20%286164%29/results.html

[Csaba Osztrogonác]

1.) css1/box_properties/acid_test.html fail caused by:
form p {
line-height: 1.9;
}

2.) css1/font_properties/font.html needs to be updated

3.) fast/forms/textarea-scrollbar-height.html fail caused by:
{font:13px/1.22 arial;}

[Csaba Osztrogonác]

original commit link: http://trac.webkit.org/changeset/49567
revert commit link: http://trac.webkit.org/changeset/53450

[Csaba Osztrogonác]

Created attachment 46899 [details]
make buildbot happy

I suggest we should update css1/font_properties/font.html and skip the others.

[Csaba Osztrogonác]

Comment on attachment 46899 [details]
make buildbot happy

landed in http://trac.webkit.org/changeset/53463

[Kent Hansen]

Can this be closed now(In reply to comment #4)
> (From update of attachment 46899 [details])
> landed in http://trac.webkit.org/changeset/53463

Can this bug be closed now, or do you intend to unskip the two tests? In any case, it might make sense to create spin-offs for those two (and add relevant dependencies) if it's not just a matter of updating the tests.

[Csaba Osztrogonác]

css1/box_properties/acid_test.html now passes, unskipped by http://trac.webkit.org/changeset/55902

fast/forms/textarea-scrollbar-height.html still fails, so we shouldn't close this bug. I think it is needless to file a new bug and dependency for only one test.

[Kent Hansen]

(In reply to comment #6)
> css1/box_properties/acid_test.html now passes, unskipped by
> http://trac.webkit.org/changeset/55902
> 
> fast/forms/textarea-scrollbar-height.html still fails, so we shouldn't close
> this bug. I think it is needless to file a new bug and dependency for only one
> test.

Cool, as long as it's just a matter of updating the test then that sounds fine.

[Csaba Osztrogonác]

(In reply to comment #7)
> Cool, as long as it's just a matter of updating the test then that sounds fine.
Unfortunately css1/box_properties/acid_test.html fails on 32 bit linux in release mode , but passes in debug mode and passes on 64 bit in release/debug mode.

It is skipped again until fix: http://trac.webkit.org/changeset/55907

see the new bug: https://bugs.webkit.org/show_bug.cgi?id=36954