Bug 33795 - [v8] [Android] V8 bindings for touch events are missing.
Summary: [v8] [Android] V8 bindings for touch events are missing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Ben Murdoch
URL:
Keywords:
Depends on:
Blocks: 32485
  Show dependency treegraph
 
Reported: 2010-01-18 05:51 PST by Ben Murdoch
Modified: 2010-02-18 02:22 PST (History)
2 users (show)

See Also:


Attachments
Patch. (5.31 KB, patch)
2010-02-17 05:07 PST, Ben Murdoch
japhet: review+
benm: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2010-01-18 05:51:12 PST
There are currently no V8 bindings upstream for touch events.

Patch to follow shortly.
Comment 1 Ben Murdoch 2010-02-17 05:07:13 PST
Created attachment 48895 [details]
Patch.
Comment 2 Nate Chapin 2010-02-17 10:46:23 PST
Comment on attachment 48895 [details]
Patch.

Looks good.

Ignorant question: Does this patch require changes to the Android build files?
Comment 3 Ben Murdoch 2010-02-17 10:57:31 PST
(In reply to comment #2)
> (From update of attachment 48895 [details])
> Looks good.
> 
> Ignorant question: Does this patch require changes to the Android build files?

Ah, I thought these were already in the upstream version of our makefile. Turns out they are not. I can amend the Android makefiles and land this patch without another review, or would you like me to send another patch?

Thanks, Ben
Comment 4 Ben Murdoch 2010-02-18 02:22:01 PST
Comment on attachment 48895 [details]
Patch.

Landed as r54950, closing bug.