Bug 33719 - [Android] Android platform specific PlatformTouchEvent and PlatformTouchPoint implementations are not upstream.
Summary: [Android] Android platform specific PlatformTouchEvent and PlatformTouchPoint...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Ben Murdoch
URL:
Keywords:
Depends on:
Blocks: 32485
  Show dependency treegraph
 
Reported: 2010-01-15 09:09 PST by Ben Murdoch
Modified: 2010-01-22 12:20 PST (History)
5 users (show)

See Also:


Attachments
Android specific files. (7.08 KB, patch)
2010-01-21 08:19 PST, Ben Murdoch
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2010-01-15 09:09:07 PST
The Android implementations of WebCore/platform/PlatformTouchEvent and WebCore/platform/PlatformTouchPoint need to be upstreamed.

Patch to follow shortly.
Comment 1 Ben Murdoch 2010-01-21 08:19:00 PST
Created attachment 47119 [details]
Android specific files.
Comment 2 Eric Seidel (no email) 2010-01-21 16:54:23 PST
Comment on attachment 47119 [details]
Android specific files.

Does this cause Andriod to pass some new tests now?
Comment 3 Ben Murdoch 2010-01-22 02:38:14 PST
(In reply to comment #2)
> (From update of attachment 47119 [details])
> Does this cause Andriod to pass some new tests now?

Well, yes and no :) There aren't many touch events test upstream yet as this feature was only landed in the last month or so, and most of those tests are synchronous whereas on Android touch events are asynchronous. So if I can refactor those tests to work in an asynchronous manner (which I've started to do locally, need to send a patch), then yes we should pass them.
Comment 4 WebKit Commit Bot 2010-01-22 03:42:13 PST
Comment on attachment 47119 [details]
Android specific files.

Rejecting patch 47119 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-javascriptcore-tests']" exit_code: 139
Last 500 characters of output:
DING NATIVE TARGET JavaScriptCore OF PROJECT JavaScriptCore WITH CONFIGURATION Release ===

Checking Dependencies...

PhaseScriptExecution /Users/eseidel/Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Script-9319586B09D9F91A00A56FD4.sh
    cd /Users/eseidel/Projects/CommitQueue/JavaScriptCore
    /bin/sh -c /Users/eseidel/Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Script-9319586B09D9F91A00A56FD4.sh
Compiling jsc failed!

Full output: http://webkit-commit-queue.appspot.com/results/203746
Comment 5 Ben Murdoch 2010-01-22 04:08:10 PST
Comment on attachment 47119 [details]
Android specific files.

Try the commit queue again, as I can't see why my patch would cause JSC to fail to compile...
Comment 6 WebKit Commit Bot 2010-01-22 04:30:29 PST
Comment on attachment 47119 [details]
Android specific files.

Clearing flags on attachment: 47119

Committed r53695: <http://trac.webkit.org/changeset/53695>
Comment 7 WebKit Commit Bot 2010-01-22 04:30:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Eric Seidel (no email) 2010-01-22 12:20:45 PST
A false failure is concerning.  Not sure what was up here.