RESOLVED FIXED33678
check-webkit-style: Eliminate error_count global state. 
https://bugs.webkit.org/show_bug.cgi?id=33678
Summary check-webkit-style: Eliminate error_count global state.
Chris Jerdonek
Reported 2010-01-14 09:49:53 PST
This is part of the FIXME to move more logic from cpp_style.py to checker.py, where appropriate.
Attachments
Proposed patch (21.39 KB, patch)
2010-01-15 21:37 PST, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-01-15 21:37:07 PST
Created attachment 46733 [details] Proposed patch
Adam Barth
Comment 2 2010-01-17 15:39:50 PST
Comment on attachment 46733 [details] Proposed patch This patch appears to do a few things at once, but this looks reasonable. Thanks for the patch.
Chris Jerdonek
Comment 3 2010-01-17 15:47:08 PST
(In reply to comment #2) > (From update of attachment 46733 [details]) > This patch appears to do a few things at once, but this looks reasonable. > Thanks for the patch. Thanks a lot for the weekend review, Adam.
WebKit Commit Bot
Comment 4 2010-01-17 16:04:42 PST
Comment on attachment 46733 [details] Proposed patch Clearing flags on attachment: 46733 Committed r53374: <http://trac.webkit.org/changeset/53374>
WebKit Commit Bot
Comment 5 2010-01-17 16:04:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.