Bug 33678 - check-webkit-style: Eliminate error_count global state.
Summary: check-webkit-style: Eliminate error_count global state.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks: 33764
  Show dependency tree / graph
 
Reported: 2010-01-14 09:49 PST by Chris Jerdonek
Modified: 2010-01-17 16:04 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (21.39 KB, patch)
2010-01-15 21:37 PST, Chris Jerdonek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-01-14 09:49:53 PST 
This is part of the FIXME to move more logic from cpp_style.py to checker.py, where appropriate.
Comment 1 Chris Jerdonek 2010-01-15 21:37:07 PST 
Created attachment 46733 [details]
Proposed patch
Comment 2 Adam Barth 2010-01-17 15:39:50 PST 
Comment on attachment 46733 [details]
Proposed patch

This patch appears to do a few things at once, but this looks reasonable.  Thanks for the patch.
Comment 3 Chris Jerdonek 2010-01-17 15:47:08 PST 
(In reply to comment #2)
> (From update of attachment 46733 [details])
> This patch appears to do a few things at once, but this looks reasonable. 
> Thanks for the patch.

Thanks a lot for the weekend review, Adam.
Comment 4 WebKit Commit Bot 2010-01-17 16:04:42 PST 
Comment on attachment 46733 [details]
Proposed patch

Clearing flags on attachment: 46733

Committed r53374: <http://trac.webkit.org/changeset/53374>
Comment 5 WebKit Commit Bot 2010-01-17 16:04:48 PST 
All reviewed patches have been landed.  Closing bug.