Bug 33764 - check-webkit-style: Finish eliminating need for global _CppStyleState instance.
Summary: check-webkit-style: Finish eliminating need for global _CppStyleState instance.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on: 33678
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-16 12:23 PST by Chris Jerdonek
Modified: 2010-01-17 19:17 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (25.33 KB, patch)
2010-01-16 13:04 PST, Chris Jerdonek 		cjerdonek: commit-queue-
Details | Formatted Diff | Diff
Proposed patch 2 (25.90 KB, patch)
2010-01-16 13:17 PST, Chris Jerdonek 		cjerdonek: commit-queue-
Details | Formatted Diff | Diff
Proposed patch 2 (resubmit) (25.90 KB, patch)
2010-01-17 16:12 PST, Chris Jerdonek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-01-16 12:23:35 PST 
Only verbose_level is left now.
Comment 1 Chris Jerdonek 2010-01-16 13:04:24 PST 
Created attachment 46746 [details]
Proposed patch

The diff for this patch assumes the patch for bug 33678 has been committed.
Comment 2 Chris Jerdonek 2010-01-16 13:17:21 PST 
Created attachment 46748 [details]
Proposed patch 2

Missed a change in checker.process_patch() and added a FIXME.
Comment 3 Chris Jerdonek 2010-01-17 16:12:24 PST 
Created attachment 46767 [details]
Proposed patch 2 (resubmit)

Resubmitting the latest patch to trigger the style-check, etc. now that the patch in bug 33678 has been committed.
Comment 4 Shinichiro Hamaji 2010-01-17 17:33:18 PST 
Comment on attachment 46767 [details]
Proposed patch 2 (resubmit)

Looks good.
Comment 5 WebKit Commit Bot 2010-01-17 18:22:50 PST 
Comment on attachment 46767 [details]
Proposed patch 2 (resubmit)

Clearing flags on attachment: 46767

Committed r53382: <http://trac.webkit.org/changeset/53382>
Comment 6 WebKit Commit Bot 2010-01-17 18:22:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Jerdonek 2010-01-17 19:17:34 PST 
(In reply to comment #4)
> (From update of attachment 46767 [details])
> Looks good.

Thanks a lot, Shinichiro.