Bug 33606 – style checker needs to know about GObject-specific requirements inside WebCore/bindings/gobject/

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gustavo Noronha (kov)]

Xan is working on finally pushing the DOM bindings patch forward again, and we will end up having the WebCore/bindings/gobject/ directory, which will contain many GObject definitions. GObject definitions require a couple of functions to initialize the class structure, and the instance structure, and they need to use lowercased, underscore-separated names (to respect the names given by a define).

Here's an example:

https://bugs.webkit.org/show_bug.cgi?id=33590#c11

[Adam Barth]

Created attachment 46764 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 46764 [details]
Patch

Rejecting patch 46764 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/webkitpy/style/cpp_style.py
Hunk #1 FAILED at 2491.
1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/style/cpp_style.py.rej
patching file WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py
Hunk #1 succeeded at 3570 with fuzz 2 (offset 23 lines).

Full output: http://webkit-commit-queue.appspot.com/results/195516

[Adam Barth]

Created attachment 46799 [details]
Patch for landing

[Adam Barth]

Comment on attachment 46799 [details]
Patch for landing

Clearing flags on attachment: 46799

Committed r53399: <http://trac.webkit.org/changeset/53399>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.