Bug 33606 - style checker needs to know about GObject-specific requirements inside WebCore/bindings/gobject/
Summary: style checker needs to know about GObject-specific requirements inside WebCor...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-01-13 09:54 PST by Gustavo Noronha (kov)
Modified: 2010-01-18 02:13 PST (History)
2 users (show)

See Also:

Patch (2.48 KB, patch)
2010-01-17 15:52 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (2.47 KB, patch)
2010-01-18 01:30 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-01-13 09:54:37 PST
Xan is working on finally pushing the DOM bindings patch forward again, and we will end up having the WebCore/bindings/gobject/ directory, which will contain many GObject definitions. GObject definitions require a couple of functions to initialize the class structure, and the instance structure, and they need to use lowercased, underscore-separated names (to respect the names given by a define).

Here's an example:

Comment 1 Adam Barth 2010-01-17 15:52:31 PST
Created attachment 46764 [details]
Comment 2 WebKit Commit Bot 2010-01-17 19:36:41 PST
Comment on attachment 46764 [details]

Rejecting patch 46764 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/webkitpy/style/cpp_style.py
Hunk #1 FAILED at 2491.
1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/style/cpp_style.py.rej
patching file WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py
Hunk #1 succeeded at 3570 with fuzz 2 (offset 23 lines).

Full output: http://webkit-commit-queue.appspot.com/results/195516
Comment 3 Adam Barth 2010-01-18 01:30:01 PST
Created attachment 46799 [details]
Patch for landing
Comment 4 Adam Barth 2010-01-18 02:13:47 PST
Comment on attachment 46799 [details]
Patch for landing

Clearing flags on attachment: 46799

Committed r53399: <http://trac.webkit.org/changeset/53399>
Comment 5 Adam Barth 2010-01-18 02:13:52 PST
All reviewed patches have been landed.  Closing bug.