Bug 33324 - Add touch point bounding rectangle sizes to touch event
Summary: Add touch point bounding rectangle sizes to touch event
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 32485
  Show dependency treegraph
 
Reported: 2010-01-07 09:10 PST by Petri Latvala
Modified: 2011-03-30 04:35 PDT (History)
8 users (show)

See Also:


Attachments
Add bounding box rectangle sizes to touch point DOM objects (17.20 KB, patch)
2010-01-07 09:16 PST, Petri Latvala
no flags Details | Formatted Diff | Diff
Touch point bounding box, updated (21.53 KB, patch)
2010-01-07 18:31 PST, Petri Latvala
no flags Details | Formatted Diff | Diff
Touch point bounding box, try 3 (20.90 KB, patch)
2010-01-07 18:38 PST, Petri Latvala
no flags Details | Formatted Diff | Diff
Touch point bounding box, try 4 (19.90 KB, patch)
2010-01-19 07:08 PST, Petri Latvala
koivisto: review-
koivisto: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petri Latvala 2010-01-07 09:10:55 PST
Expose touch point bounding rectangle size to the javascript DOM event.
Comment 1 Petri Latvala 2010-01-07 09:16:16 PST
Created attachment 46057 [details]
Add bounding box rectangle sizes to touch point DOM objects
Comment 2 WebKit Review Bot 2010-01-07 09:20:03 PST
style-queue ran check-webkit-style on attachment 46057 [details] without any errors.
Comment 3 Petri Latvala 2010-01-07 18:31:55 PST
Created attachment 46105 [details]
Touch point bounding box, updated

Badly timed preparation for that earlier patch. This one is against the current HEAD.
Comment 4 Petri Latvala 2010-01-07 18:38:32 PST
Created attachment 46106 [details]
Touch point bounding box, try 3

...and that one got diffed incorrectly, and changelog whitespaces were munged. Fixed.
Comment 5 WebKit Review Bot 2010-01-07 18:41:21 PST
style-queue ran check-webkit-style on attachment 46106 [details] without any errors.
Comment 6 Simon Hausmann 2010-01-16 00:39:14 PST
David, Ben: Any thoughts on adding these properties to the JS API?
Comment 7 Ben Murdoch 2010-01-19 03:18:15 PST
(In reply to comment #6)
> David, Ben: Any thoughts on adding these properties to the JS API?

I don't see any harm in adding these properties. However Android does not support touch point bounding boxes so on Android they will always be empty (I see from the QTouchEvent::TouchPoint API that for the rect() function there is a note "This function returns an empty rect if the device does not report touch point sizes.")

Looking at the patch, I see that the basic touch test has been augmented with the bounding box information. Would it be possible to move it into it's own test so that we can skip it on Android?

Cheers, Ben
Comment 8 Petri Latvala 2010-01-19 03:27:44 PST
(In reply to comment #7)
> Looking at the patch, I see that the basic touch test has been augmented with
> the bounding box information. Would it be possible to move it into it's own
> test so that we can skip it on Android?

Certainly, I'll prepare a new patch that does that.
Comment 9 Petri Latvala 2010-01-19 07:08:53 PST
Created attachment 46905 [details]
Touch point bounding box, try 4

Touch point bounding rectangle with a new test for it, along with some additional minor changes in the implementation compared to the previous patches.
Comment 10 Holger Freyther 2010-02-01 23:23:27 PST
Just to be pedantic here. A point does not have a bounding rect...  When creating JS API you want to support for years to come you should consider this...
Comment 11 Antti Koivisto 2010-03-08 05:51:11 PST
Comment on attachment 46905 [details]
Touch point bounding box, try 4

I don't think we want to add the feature at this point to the mainline WebKit

- The touch event API is completely new and not yet standardized. I think it is better to have a compact API covering the most important use cases first and gain some experience before piling in new features.
- Use cases for the feature are not clear so it is hard to evaluate the proposed API. If the main use of the feature is obtaining the strength of the press, would it be better to express that directly as a single number? If the touch shape is really important isn't an axis-aligned bounding rect too coarse grained way of describing it?
- Platform support is limited (per comments above Android can't do it for example)
- As zecke pointed out, the concept of point bounds is nonsensical.

r- on these grounds.
Comment 12 Benjamin Poulain 2011-03-30 04:35:01 PDT
I close the bug. This is still being discussed in standardization.
We can open a bug later when the draft is in a better shape.