RESOLVED FIXED Bug 33034
[v8] Move world-specific state out of V8Proxy 
https://bugs.webkit.org/show_bug.cgi?id=33034
Summary [v8] Move world-specific state out of V8Proxy
Adam Barth
Reported 2009-12-29 18:08:07 PST
[v8] Move window-specific state out of V8Proxy
Attachments
Patch (60.09 KB, patch)
2009-12-29 18:12 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (60.07 KB, patch)
2009-12-29 18:28 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-29 18:12:52 PST
Created attachment 45625 [details] Patch
WebKit Review Bot
Comment 2 2009-12-29 18:18:02 PST
Attachment 45625 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/V8DOMWindowShell.h:36: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:37: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:62: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:288: Use 0 instead of NULL. [readability/null] [4] Total errors found: 5
Adam Barth
Comment 3 2009-12-29 18:28:12 PST
Created attachment 45626 [details] Patch
WebKit Review Bot
Comment 4 2009-12-29 18:33:53 PST
Attachment 45626 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/V8DOMWindowShell.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2
Adam Barth
Comment 5 2009-12-29 18:36:57 PST
Style errors are false positives: https://bugs.webkit.org/show_bug.cgi?id=33037
Eric Seidel (no email)
Comment 6 2009-12-29 23:51:00 PST
Comment on attachment 45626 [details] Patch I did not review the + lines careful as I assumed they were all copy code. I did look carefully at the - lines however. This looks sane to me.
Dimitri Glazkov (Google)
Comment 7 2009-12-30 08:38:42 PST
This looks pretty cool.
Adam Barth
Comment 8 2009-12-30 10:23:05 PST
Comment on attachment 45626 [details] Patch Clearing flags on attachment: 45626 Committed r52666: <http://trac.webkit.org/changeset/52666>
Adam Barth
Comment 9 2009-12-30 10:23:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.