[v8] Move window-specific state out of V8Proxy
Created attachment 45625 [details] Patch
Attachment 45625 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/V8DOMWindowShell.h:36: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:37: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:62: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:288: Use 0 instead of NULL. [readability/null] [4] Total errors found: 5
Created attachment 45626 [details] Patch
Attachment 45626 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/V8DOMWindowShell.cpp:35: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/v8/V8DOMWindowShell.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2
Style errors are false positives: https://bugs.webkit.org/show_bug.cgi?id=33037
Comment on attachment 45626 [details] Patch I did not review the + lines careful as I assumed they were all copy code. I did look carefully at the - lines however. This looks sane to me.
This looks pretty cool.
Comment on attachment 45626 [details] Patch Clearing flags on attachment: 45626 Committed r52666: <http://trac.webkit.org/changeset/52666>
All reviewed patches have been landed. Closing bug.