RESOLVED INVALID33037
[check-webkit-style] Include order should understand uppercase 
https://bugs.webkit.org/show_bug.cgi?id=33037
Summary [check-webkit-style] Include order should understand uppercase
Adam Barth
Reported 2009-12-29 18:35:02 PST
[check-webkit-style] Include order should understand uppercase
Attachments
Patch (2.71 KB, patch)
2009-12-29 18:36 PST, Adam Barth 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-29 18:36:06 PST
Created attachment 45627 [details] Patch
WebKit Review Bot
Comment 2 2009-12-29 18:39:15 PST
style-queue ran check-webkit-style on attachment 45627 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-29 23:52:55 PST
Comment on attachment 45627 [details] Patch I'm slightly confused by this. I think the sort order sorta defined to be whatever XCode's "sort lines" applescript thing does. This makes our sort order looser, which is probably good, but I'm not sure which editors will care.
Adam Barth
Comment 4 2009-12-30 14:02:04 PST
Oh, we could do that. The current thing is very braindead. It thinks that capital letter always go ahead (or behind) their lowercase compatriots. Ab aa So, it wants things sorted as above, which is nonsensical to me.
Mark Rowe (bdash)
Comment 5 2009-12-30 16:42:07 PST
Our style guide says: > Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). This patch appears to be trying to enforce case-insensitive ordering.
Adam Barth
Comment 6 2009-12-30 17:32:41 PST
Comment on attachment 45627 [details] Patch Ah, so this patch is wrong then. I think the current behavior is wrong too, but I'll check against the "sort" command.
Adam Barth
Comment 7 2009-12-30 17:34:34 PST
According to "sort", the script is currently correct. Wacky, but correct. $ echo "aa > Ab" | sort Ab aa
Note You need to log in before you can comment on or make changes to this bug.