Bug 33009 - Need a script to assign bugs with r+ patches to committers for landing
Summary: Need a script to assign bugs with r+ patches to committers for landing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 32995
Blocks:
  Show dependency tree / graph
 
Reported: 2009-12-28 22:43 PST by Eric Seidel (no email)
Modified: 2009-12-29 20:48 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.21 KB, patch)
2009-12-28 22:48 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (16.90 KB, patch)
2009-12-29 20:32 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-28 22:43:45 PST 
Need a script to assign bugs with r+ patches to committers for landing

Many bugs get landed, and committers forget to close them.  Or patches get posted and r+'d and committers forget about them.  We need a script to at least handle the one-time reminder of assigning a bug to a committer for landing.  That also makes it easier to see which bugs do not belong to committers in:
http://webkit.org/pending-commit

I've written a bugzilla-tool command do do this and will attach a patch.
Comment 1 Eric Seidel (no email) 2009-12-28 22:48:55 PST 
Created attachment 45587 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-12-28 22:49:27 PST 
This can't be commit-queue'd until bug 32995 is landed.
Comment 3 Adam Barth 2009-12-29 11:03:38 PST 
Comment on attachment 45587 [details]
Patch

+ FIXME: This can be removed once Command understands help_text like AbstractSequencedCommmand does

You're looking for DeclarativeCommand, which knows how to do this.

+ reviwed_patches

Typo

+ Bug %s likely needs commit-queue

I'd make this a link for easy clickability.

R- because you didn't add any tests!
Comment 4 Eric Seidel (no email) 2009-12-29 20:32:22 PST 
Created attachment 45634 [details]
Patch
Comment 5 WebKit Review Bot 2009-12-29 20:32:54 PST 
style-queue ran check-webkit-style on attachment 45634 [details] without any errors.
Comment 6 Adam Barth 2009-12-29 20:40:03 PST 
Comment on attachment 45634 [details]
Patch

ship it!
Comment 7 WebKit Commit Bot 2009-12-29 20:48:09 PST 
Comment on attachment 45634 [details]
Patch

Clearing flags on attachment: 45634

Committed r52641: <http://trac.webkit.org/changeset/52641>
Comment 8 WebKit Commit Bot 2009-12-29 20:48:15 PST 
All reviewed patches have been landed.  Closing bug.