Bug 32995 - Add the start of a Bug object for bugzilla.py
Summary: Add the start of a Bug object for bugzilla.py
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 33009
  Show dependency treegraph
Reported: 2009-12-28 14:34 PST by Eric Seidel (no email)
Modified: 2009-12-29 11:33 PST (History)
3 users (show)

See Also:

Patch (12.46 KB, patch)
2009-12-28 15:23 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-28 14:34:21 PST
Add the start of a Bug object for bugzilla.py

I also fixed the __all__ issue for buildsteps.py, but I can split that out into a separate change if necessary.
Comment 1 Eric Seidel (no email) 2009-12-28 15:23:05 PST
Created attachment 45578 [details]
Comment 2 WebKit Review Bot 2009-12-28 15:28:18 PST
style-queue ran check-webkit-style on attachment 45578 [details] without any errors.
Comment 3 Adam Barth 2009-12-29 10:58:07 PST
Comment on attachment 45578 [details]

Certainly not the last word, but progress nonetheless.

W.r.t. not all the steps having "Step" in their names: that's just a mistake.  We should put them into a step module and call then step.Commit  and  step.EnsureBuildersAreGreen.  The "build" in buildsteps is a misnomer now.
Comment 4 WebKit Commit Bot 2009-12-29 11:03:23 PST
Comment on attachment 45578 [details]

Rejecting patch 45578 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests
Testing 11854 test cases.
fast/css/non-standard-checkbox-size.html -> failed

Exiting early after 1 failures. 5218 tests run.
76.31s total testing time

5217 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/150775
Comment 5 Eric Seidel (no email) 2009-12-29 11:08:09 PST
The failure is bogus.  The test was added by bug 28631.  This is due to bug 28603.
Comment 6 Eric Seidel (no email) 2009-12-29 11:17:19 PST
Comment on attachment 45578 [details]

Sorry.  We were bit by bug 28603.  I've fixed the commit bot for now.
Comment 7 WebKit Commit Bot 2009-12-29 11:33:12 PST
Comment on attachment 45578 [details]

Clearing flags on attachment: 45578

Committed r52628: <http://trac.webkit.org/changeset/52628>
Comment 8 WebKit Commit Bot 2009-12-29 11:33:17 PST
All reviewed patches have been landed.  Closing bug.