Bug 32942 - HTML5 <article> element support
: HTML5 <article> element support
Status: RESOLVED FIXED
: WebKit
HTML DOM
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
: http://www.whatwg.org/specs/web-apps/...
:
:
: 32934
  Show dependency treegraph
 
Reported: 2009-12-25 21:33 PST by
Modified: 2009-12-28 08:34 PST (History)


Attachments
Proposed patch (9.66 KB, patch)
2009-12-25 21:59 PST, Kent Tamura
mjs: review+
commit-queue: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-12-25 21:33:10 PST
Implement <article> element.  It will be very similar to Bug#32936 for <section>.
------- Comment #1 From 2009-12-25 21:59:20 PST -------
Created an attachment (id=45505) [details]
Proposed patch
------- Comment #2 From 2009-12-25 22:02:07 PST -------
style-queue ran check-webkit-style on attachment 45505 [details] without any errors.
------- Comment #3 From 2009-12-28 02:10:48 PST -------
(From update of attachment 45505 [details])
r=me
------- Comment #4 From 2009-12-28 04:36:18 PST -------
(From update of attachment 45505 [details])
Rejecting patch 45505 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '45505']" exit_code: 1
Last 500 characters of output:
134, in fetch_attachments_from_bug
    bug = self.fetch_bug(bug_id)
  File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 130, in fetch_bug
    return self._parse_bug_page(page)
  File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 123, in _parse_bug_page
    bug["attachments"] = [self._parse_attachment_element(element, bug_id) for element in soup.findAll('attachment')]
NameError: global name 'bug_id' is not defined
------- Comment #5 From 2009-12-28 05:49:42 PST -------
Landed manually as r52596 <http://trac.webkit.org/changeset/52596>
------- Comment #6 From 2009-12-28 08:34:36 PST -------
Sorry, I broke the commit-queue, but Adam fixed it in http://trac.webkit.org/changeset/52595.  Its working again now.  Apologies for the trouble.