Bug 32942

Summary: HTML5 <article> element support
Product: WebKit Reporter: Kent Tamura <tkent>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric, mjs, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/sections.html#the-article-element
Bug Depends on:    
Bug Blocks: 32934    
Attachments:
Description Flags
Proposed patch mjs: review+, commit-queue: commit-queue-

Description Kent Tamura 2009-12-25 21:33:10 PST 
Implement <article> element.  It will be very similar to Bug#32936 for <section>.
Comment 1 Kent Tamura 2009-12-25 21:59:20 PST 
Created attachment 45505 [details]
Proposed patch
Comment 2 WebKit Review Bot 2009-12-25 22:02:07 PST 
style-queue ran check-webkit-style on attachment 45505 [details] without any errors.
Comment 3 Maciej Stachowiak 2009-12-28 02:10:48 PST 
Comment on attachment 45505 [details]
Proposed patch

r=me
Comment 4 WebKit Commit Bot 2009-12-28 04:36:18 PST 
Comment on attachment 45505 [details]
Proposed patch

Rejecting patch 45505 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.
Failed to run "['WebKitTools/Scripts/bugzilla-tool', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '45505']" exit_code: 1
Last 500 characters of output:
134, in fetch_attachments_from_bug
    bug = self.fetch_bug(bug_id)
  File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 130, in fetch_bug
    return self._parse_bug_page(page)
  File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 123, in _parse_bug_page
    bug["attachments"] = [self._parse_attachment_element(element, bug_id) for element in soup.findAll('attachment')]
NameError: global name 'bug_id' is not defined
Comment 5 Kent Tamura 2009-12-28 05:49:42 PST 
Landed manually as r52596 <http://trac.webkit.org/changeset/52596>
Comment 6 Eric Seidel (no email) 2009-12-28 08:34:36 PST 
Sorry, I broke the commit-queue, but Adam fixed it in http://trac.webkit.org/changeset/52595.  Its working again now.  Apologies for the trouble.