Extracted from the changes in the patch for bug #27895. We should clean up the XSSAuditor so that we don't need to pass as many parameters around. Currently, we pass various parameters through to XSSAuditor::findInRequest that are used to determine how to decode the HTTP input parameters so that we can perform a match against the script source.
Created attachment 45495 [details] Patch No functionality was changed. So, no new tests.
Attachment 45495 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/page/XSSAuditor.cpp:356: One space before end of line comments [whitespace/comments] [5] WebCore/page/XSSAuditor.cpp:361: One space before end of line comments [whitespace/comments] [5] Total errors found: 2
Created attachment 45496 [details] Patch Fix style-bot errors.
style-queue ran check-webkit-style on attachment 45496 [details] without any errors.
Comment on attachment 45496 [details] Patch This looks great. One nit: 147 task.decodeEntities = true; You don't need these assignments because decodeEntities defaults to true. We needed them originally because the parameters were in a fixed order. Other than that, looks great. Thanks Dan.
Will remove before I land. (In reply to comment #5) > (From update of attachment 45496 [details]) > This looks great. One nit: > > 147 task.decodeEntities = true; > > You don't need these assignments because decodeEntities defaults to true. We > needed them originally because the parameters were in a fixed order. > > Other than that, looks great. Thanks Dan.
Committed in <http://trac.webkit.org/changeset/52561>.