Bug 32755 – upstream various forms tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dirk Pranke]

Upstreaming a bunch of forms tests from chromium.org

[Dirk Pranke]

Created attachment 45207 [details]
Patch

[Dirk Pranke]

Created attachment 45212 [details]
Patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45212 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 45212 [details]
Patch

I'm confused from the diff as to if this is just adding new tests or modifying existing ones.

[Dirk Pranke]

this adds seven new tests upstream.

[Eric Seidel (no email)]

Comment on attachment 45212 [details]
Patch

OK.

[WebKit Commit Bot]

Comment on attachment 45212 [details]
Patch

Rejecting patch 45212 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
 MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe
svnlook: Can't write to stream: Broken pipe

    The following files contain tab characters:

        trunk/LayoutTests/fast/forms/style-display-none.html

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 558


Full output: http://webkit-commit-queue.appspot.com/results/138484

[Dirk Pranke]

Created attachment 45402 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 45402 [details]
Patch

OK.

[WebKit Commit Bot]

Comment on attachment 45402 [details]
Patch

Clearing flags on attachment: 45402

Committed r52502: <http://trac.webkit.org/changeset/52502>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Comment on attachment 45402 [details]
Patch

Eek!  The ChangeLog was compeltely wrong here.  My fault for not catching it.

[Brian Weinstein]

I landed platform specific results for Windows for basic-textarea-quirks in r52533. It would be nice if someone could let me know if this is expected different behavior or if this is a bug.

[Dirk Pranke]

(In reply to comment #13)
> I landed platform specific results for Windows for basic-textarea-quirks in
> r52533. It would be nice if someone could let me know if this is expected
> different behavior or if this is a bug.

I would expect the windows results to be different from the mac results. Does that answer your question?

[Brian Weinstein]

(In reply to comment #14)
> (In reply to comment #13)
> > I landed platform specific results for Windows for basic-textarea-quirks in
> > r52533. It would be nice if someone could let me know if this is expected
> > different behavior or if this is a bug.
> 
> I would expect the windows results to be different from the mac results. Does
> that answer your question?

Yeah, thanks!

[Alexey Proskuryakov]

*** Bug 22656 has been marked as a duplicate of this bug. ***