Bug 32755 - upstream various forms tests
Summary: upstream various forms tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
: 22656 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-18 16:34 PST by Dirk Pranke
Modified: 2010-04-26 19:10 PDT (History)
6 users (show)

See Also:


Attachments
Patch (122.52 KB, patch)
2009-12-18 16:34 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (473.24 KB, patch)
2009-12-18 16:53 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (473.71 KB, patch)
2009-12-22 14:03 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2009-12-18 16:34:05 PST
Upstreaming a bunch of forms tests from chromium.org
Comment 1 Dirk Pranke 2009-12-18 16:34:54 PST
Created attachment 45207 [details]
Patch
Comment 2 Dirk Pranke 2009-12-18 16:53:29 PST
Created attachment 45212 [details]
Patch
Comment 3 WebKit Review Bot 2009-12-18 16:54:59 PST
style-queue ran check-webkit-style on attachment 45212 [details] without any errors.
Comment 4 Eric Seidel (no email) 2009-12-19 12:23:14 PST
Comment on attachment 45212 [details]
Patch

I'm confused from the diff as to if this is just adding new tests or modifying existing ones.
Comment 5 Dirk Pranke 2009-12-21 14:22:00 PST
this adds seven new tests upstream.
Comment 6 Eric Seidel (no email) 2009-12-22 13:24:53 PST
Comment on attachment 45212 [details]
Patch

OK.
Comment 7 WebKit Commit Bot 2009-12-22 13:51:42 PST
Comment on attachment 45212 [details]
Patch

Rejecting patch 45212 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
 MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe
svnlook: Can't write to stream: Broken pipe

    The following files contain tab characters:

        trunk/LayoutTests/fast/forms/style-display-none.html

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 558


Full output: http://webkit-commit-queue.appspot.com/results/138484
Comment 8 Dirk Pranke 2009-12-22 14:03:08 PST
Created attachment 45402 [details]
Patch
Comment 9 Eric Seidel (no email) 2009-12-22 14:05:35 PST
Comment on attachment 45402 [details]
Patch

OK.
Comment 10 WebKit Commit Bot 2009-12-22 14:26:30 PST
Comment on attachment 45402 [details]
Patch

Clearing flags on attachment: 45402

Committed r52502: <http://trac.webkit.org/changeset/52502>
Comment 11 WebKit Commit Bot 2009-12-22 14:26:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Eric Seidel (no email) 2009-12-22 14:37:40 PST
Comment on attachment 45402 [details]
Patch

Eek!  The ChangeLog was compeltely wrong here.  My fault for not catching it.
Comment 13 Brian Weinstein 2009-12-23 16:35:30 PST
I landed platform specific results for Windows for basic-textarea-quirks in r52533. It would be nice if someone could let me know if this is expected different behavior or if this is a bug.
Comment 14 Dirk Pranke 2009-12-28 12:19:06 PST
(In reply to comment #13)
> I landed platform specific results for Windows for basic-textarea-quirks in
> r52533. It would be nice if someone could let me know if this is expected
> different behavior or if this is a bug.

I would expect the windows results to be different from the mac results. Does that answer your question?
Comment 15 Brian Weinstein 2009-12-28 12:39:15 PST
(In reply to comment #14)
> (In reply to comment #13)
> > I landed platform specific results for Windows for basic-textarea-quirks in
> > r52533. It would be nice if someone could let me know if this is expected
> > different behavior or if this is a bug.
> 
> I would expect the windows results to be different from the mac results. Does
> that answer your question?

Yeah, thanks!
Comment 16 Alexey Proskuryakov 2010-04-26 19:10:56 PDT
*** Bug 22656 has been marked as a duplicate of this bug. ***