WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 32755
22656
tests document.write()
https://bugs.webkit.org/show_bug.cgi?id=22656
Summary
tests document.write()
Danish Shrestha
Reported
2008-12-04 12:10:17 PST
This patch tests that document.write() with no parameters does not output any text.
Attachments
patch for testing document.write
(906 bytes, patch)
2008-12-04 12:11 PST
,
Danish Shrestha
darin
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Danish Shrestha
Comment 1
2008-12-04 12:11:01 PST
Created
attachment 25746
[details]
patch for testing document.write
Darin Adler
Comment 2
2008-12-04 16:01:35 PST
Comment on
attachment 25746
[details]
patch for testing document.write This test looks fine, but the patch needs to also include a ChangeLog entry. Also, we prefer to have the "newline at end of file" unless there's a reason not to have it. Also, we prefer tests that cover a bit more per test. It's OK to have a test that tests only this one targeted thing, but it's better to cover more per test so our tests cover a lot of different cases and run quickly.
Joseph Pecoraro
Comment 3
2010-04-26 15:34:43 PDT
It looks like testing an empty document.write is now covered by: LayoutTests/fast/forms/document-write-empty.html The Git/SVN/Trac History of this file seems to be confused:
http://trac.webkit.org/browser/trunk/LayoutTests/fast/forms/document-write-empty.html?rev=58265
The content is essentially identical, and the test's description is verbatim! I don't really know what is best, so I'm closing this as "Works For Me" because there is now a test. I'd mark it a duplicate, but I can't accurately find the original bug.
Alexey Proskuryakov
Comment 4
2010-04-26 19:10:56 PDT
*** This bug has been marked as a duplicate of
bug 32755
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug