Bug 32500 - Improve CSS3 Glyphs Support for lists and text security
Summary: Improve CSS3 Glyphs Support for lists and text security
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-13 16:16 PST by Adam M-W
Modified: 2009-12-24 11:10 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam M-W 2009-12-13 16:16:12 PST
The CSS3 Definition defines glyphs for box, check, circle, diamond, disc, hyphen and square.
These glyphs should be added to both the text security properties and CSS list values (see /WebCore/rendering/RenderText.cpp and /WebCore/rendering/RenderListMarker.cpp)

Currently, circle, disc and square are already implemented which leaves box (U+25FD), check (U+2713), diamond (U+25C6) and hyphen (U+2043) to be implemented.

Further information can be found at http://www.w3.org/TR/2002/WD-css3-lists-20021107/#glyphs
Comment 1 Alexey Proskuryakov 2009-12-14 15:33:44 PST
Updating list-style-type properties sounds fine, although I'm not sure if a spec from 2002 should be considered authoritative. Do other browsers support all those values?

As for -webkit-text-security, it doesn't seem related to me. Is there any indication anywhere that it should support that same glyphs as list-style-type?
Comment 2 Adam M-W 2009-12-14 18:03:25 PST
Some other CSS3 that's even older has already been implemented, why wait longer?
As long as if the recommendation changes (which it probably won't in regard to glyphs as there are NO comments on it so far) we update WebKit to match, i don't see a problem. WebKit already uses stuff like CSS3 Backgrounds which are WD so should be fine.

I've just done a quick check now, and it doesn't seem that other browsers support it (tested FF 3.5, IE 8) but that shouldn't stop us, as it won't ruin the default behaviour only improve support where specified.

I've recommended webkit-text-security be updated as well as the current code references the glyphs from the text-security module as they are used there as well, so doing so for these new glyphs allows for code to be re-used and similar to existing code, and also gives new webkit-specific features in terms of new symbols (can't hurt).

I thought that this should be a realitivly simple task as most code can be copied and renamed, but I couldn't find where they were set in text-security so I couldn't create a patch. (ergo the bug report / feature request).

(Also I've got no idea how to make testcases so I'd thought I'd leave it to the experts)
Comment 3 Daniel Bates 2009-12-24 11:10:29 PST
For your reference, this bug is related to bug #32138 ("Upper-greek list-style not supported"). We also landed a cleanup bug #32799 to clear the way for adding more list styles.