Bug 32799 – Cleanup: Rename CSS list-style-type markers to conform to WebKit Code Style Guidelines

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Daniel Bates]

Following up on a suggestion by Darin <https://bugs.webkit.org/show_bug.cgi?id=32138#c5>, we should rename the enums in RenderStyleConstants::EListStyleType to conform to the WebKit Code Style Guidelines.

[Daniel Bates]

Created attachment 45288 [details]
Patch

No functionality was changed. So, no tests included in patch.

[WebKit Review Bot]

Attachment 45288 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/css/CSSPrimitiveValueMappings.h:933:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListItem.cpp:54:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/RenderListMarker.cpp:343:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:574:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:696:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:776:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:793:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:839:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 8

[Daniel Bates]

Created attachment 45289 [details]
Patch with style-bot fixes (maybe we should do these fixes in a separate bug?)

An updated patch with more style corrections to make the style-bot happy.

I think I recall seeing a webkit-dev post about allowing switch indents when there are many cases. Maybe we can disagree with the style-bot (and not use this attachment) since the cleanup requires us to touch some switch statements that have many cases?

Also, if we do decide to go with the style-bot's suggestions then we may want to do these changes as part of a separate bug(s).

[Darin Adler]

Comment on attachment 45288 [details]
Patch

I think that DecimalListStyle would be better than LDecimal and NoneListStyle better than LNone.

[Daniel Bates]

Created attachment 45306 [details]
Patch

Updated patch based on Darin's suggestion to substitute DecimalListStyle for LDecimal and NoneListStyle for LNone.

[WebKit Review Bot]

Attachment 45306 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/css/CSSPrimitiveValueMappings.h:939:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:343:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:574:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:696:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:776:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:793:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/rendering/RenderListMarker.cpp:839:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 7

[Eric Seidel (no email)]

Comment on attachment 45306 [details]
Patch

Maybe more should ahve the ListStyle postfix, but this seems better than what we had before.  r=me.

[Daniel Bates]

Committed in <http://trac.webkit.org/changeset/52521>.