Bug 32482 – [Qt] Add support for keyboard modifiers to TouchEvent

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

The iPhone's TouchEvent interface provides access to the keyboard modifiers as properties.

QTouchEvent has the same properties and it should be straight-forward to map those and test the mapping.

(This issue is part of http://bugreports.qt.nokia.com/browse/QTWEBKIT-20 )

[Simon Hausmann]

Created attachment 44766 [details]
Patch

[Simon Hausmann]

Created attachment 44767 [details]
Patch with corrected coding style

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44767 [details] without any errors.

[Holger Freyther]

Comment on attachment 44767 [details]
Patch with corrected coding style

Do you plan to do dump the other modifiers in the test case too? It would be interesting to set two modifiers at the same time... mostly to test the bit setting, clearling logic in the Event Sender :)


>      : MouseRelatedEvent(type, true, true, view, 0, screenX, screenY, pageX, pageY,
> -                        false, false, false, false)
> +                        ctrlKey, altKey, shiftKey, metaKey)

maybe add isSimulated as well... that is the only missing one from MouseRelatedEvent...



> +            bool ctrlKey, bool altKey, bool shiftKey, bool metaKey);
>  
>      virtual bool isTo
> +        : m_type(TouchStart)
> +        , m_shiftKey(false)
> +        , m_ctrlKey(false)
> +        , m_altKey(false)
> +        , m_metaKey(false)
> +    {}


and in Qt you change the order... but I don't see an issue with it.

> +void EventSender::setTouchModifier(const QString &modifier, bool enable)
> +{
> +#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
> +    Qt::KeyboardModifier mod = Qt::NoModifier;
> +    if (!modifier.compare(QLatin1String("shift"), Qt::CaseInsensitive))
> +        mod = Qt::ShiftModifier;
> +    else if (!modifier.compare(QLatin1String("alt"), Qt::CaseInsensitive))
> +        mod = Qt::AltModifier;
> +    else if (!modifier.compare(QLatin1String("meta"), Qt::CaseInsensitive))
> +        mod = Qt::MetaModifier;
> +    else if (!modifier.compare(QLatin1String("ctrl"), Qt::CaseInsensitive))
> +        mod = Qt::ControlModifier;

I'm confused about the "!". Can you explain?

[Simon Hausmann]

(In reply to comment #4)
> (From update of attachment 44767 [details])
> Do you plan to do dump the other modifiers in the test case too? It would be
> interesting to set two modifiers at the same time... mostly to test the bit
> setting, clearling logic in the Event Sender :)

Ok, will do :)

> >      : MouseRelatedEvent(type, true, true, view, 0, screenX, screenY, pageX, pageY,
> > -                        false, false, false, false)
> > +                        ctrlKey, altKey, shiftKey, metaKey)
> 
> maybe add isSimulated as well... that is the only missing one from
> MouseRelatedEvent...

Hm, I could, but it would be completely unused AFAICS.

> > +            bool ctrlKey, bool altKey, bool shiftKey, bool metaKey);
> >  
> >      virtual bool isTo
> > +        : m_type(TouchStart)
> > +        , m_shiftKey(false)
> > +        , m_ctrlKey(false)
> > +        , m_altKey(false)
> > +        , m_metaKey(false)
> > +    {}
> 
> 
> and in Qt you change the order... but I don't see an issue with it.

Hehe, copy & paste. Will fix

> > +void EventSender::setTouchModifier(const QString &modifier, bool enable)
> > +{
> > +#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
> > +    Qt::KeyboardModifier mod = Qt::NoModifier;
> > +    if (!modifier.compare(QLatin1String("shift"), Qt::CaseInsensitive))
> > +        mod = Qt::ShiftModifier;
> > +    else if (!modifier.compare(QLatin1String("alt"), Qt::CaseInsensitive))
> > +        mod = Qt::AltModifier;
> > +    else if (!modifier.compare(QLatin1String("meta"), Qt::CaseInsensitive))
> > +        mod = Qt::MetaModifier;
> > +    else if (!modifier.compare(QLatin1String("ctrl"), Qt::CaseInsensitive))
> > +        mod = Qt::ControlModifier;
> 
> I'm confused about the "!". Can you explain?

QString::compare returns an int, similar to strcmp, which is zero when the strings are equal ;(

[Simon Hausmann]

Created attachment 44776 [details]
Updated patch with better tests

[Simon Hausmann]

Created attachment 44778 [details]
Updated patch with indenting glitch in TouchEvent.idl fixed

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44778 [details] without any errors.

[WebKit Commit Bot]

Comment on attachment 44778 [details]
Updated patch with indenting glitch in TouchEvent.idl fixed

Clearing flags on attachment: 44778

Committed r52113: <http://trac.webkit.org/changeset/52113>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.