Bug 32343 - commit-queue should reject/handle patches missing Reviewed by line
Summary: commit-queue should reject/handle patches missing Reviewed by line
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 26927
Blocks:
  Show dependency tree / graph
 
Reported: 2009-12-09 13:19 PST by Eric Seidel (no email)
Modified: 2009-12-27 19:02 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-09 13:19:22 PST 
commit-queue should reject/handle patches missing Reviewed by line

If contributors delete the "Reviewed by" line then the commit-queue will happily land a patch w/o listing the reviewer in the ChangeLog.  This is bad. :(
http://trac.webkit.org/changeset/51910
Comment 1 Eric Seidel (no email) 2009-12-27 19:02:22 PST 
Bug 32940 is another example of where this would be useful.