Bug 32042 - style-queue (or something) should r- patches missing ChangeLogs
Summary: style-queue (or something) should r- patches missing ChangeLogs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 61458 62021 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-01 17:16 PST by Eric Seidel (no email)
Modified: 2013-03-25 13:46 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-01 17:16:46 PST 
style-queue (or something) should r- patches missing ChangeLogs

Or at least make a nasty comment in the bug.  Rarely can one actually review a patch w/o a ChangeLog.

We have at least one other bug about our tools warning us sooner, but if style-queue is the earliest we can get a warning, then so be it.  It's better than the current pre-commit hook or reviewers spending time on it.

The bot should point people to http://webkit.org/coding/contributing.html or possibly http://webkit.org/coding/contributing.html#changelogs
Comment 1 Alexey Proskuryakov 2009-12-02 10:48:48 PST 
A helpful comment would be OK, but you'd need to nominate the tool for reviewer status to actually r-. 

And there are cases when it makes more sense to just manually adapt and land a one time contributor's patch than to educate them about our process. Sometimes people do useful things without long-term involvement with the project.
Comment 2 Alexey Proskuryakov 2013-03-25 13:46:23 PDT 
*** Bug 61458 has been marked as a duplicate of this bug. ***
Comment 3 Alexey Proskuryakov 2013-03-25 13:46:42 PDT 
*** Bug 62021 has been marked as a duplicate of this bug. ***