I've marked some tests as skipped for Qt in Bug 23264. Two of them can be rewritten using dumpAsText. fast/block/positioning/complex-percentage-height.html fast/lists/item-not-in-list-line-wrapping.html
Created attachment 44064 [details] Patch v1
style-queue ran check-webkit-style on attachment 44064 [details] without any errors.
Comment on attachment 44064 [details] Patch v1 The plain text tests cover a lot less than the render tree dump tests. It's more portable between platforms, and more focused, but losing the coverage is not so great. I am not certain enough about this to say review+ myself at the moment. Sorry; I won't stand in the way if someone else is more sure this is the right thing to do.
Created attachment 44128 [details] Patch v2
style-queue ran check-webkit-style on attachment 44128 [details] without any errors.
> Patch v2 Fixing a silly mistake in a test case, this doesn't change the logic and the result of the test case though. - var redHeight = gebi("warper").offsetHeight; + var blueHeight = gebi("warper").offsetHeight; var yellowHeight = gebi("abs_100_height").offsetHeight; - var blueHeight = gebi("inner_abs_100_height").offsetHeight; + var redHeight = gebi("inner_abs_100_height").offsetHeight;
CCing original authors of these tests. Darin, I understand your concern. I confirmed that these tests fail if I reverse-patch the following fixes. Of course, I know this fact doesn't show I didn't lose any information from the original test, though. Please let me know if there are some more information I can tell. Or, if you feel you'd never be confident, please let me know and I'll just update the expectations of these tests. https://bugs.webkit.org/show_bug.cgi?id=13887 https://bugs.webkit.org/show_bug.cgi?id=12746
Comment on attachment 44128 [details] Patch v2 OK
Comment on attachment 44128 [details] Patch v2 Let me check commit-queue can handle binary deletion in git patch.
Comment on attachment 44128 [details] Patch v2 Clearing flags on attachment: 44128 Committed r51626: <http://trac.webkit.org/changeset/51626>
All reviewed patches have been landed. Closing bug.
(In reply to comment #11) > All reviewed patches have been landed. Closing bug. It seems working. Thanks Darin for your review.